[msbuild] Enable nullability in WriteItemsToFile and fix any issues. #20099
Conversation
💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
|
|
||
| document.Save (this.File.ItemSpec); | ||
| document.Save (file); |
There was a problem hiding this comment.
If I am not mistaken, file here can be null as per:
var file = this.File?.ItemSpec;and at least in dotnet7 if you pass null to save you'll get the following:
Unhandled exception. System.ArgumentNullException: Value cannot be null. (Parameter 'outputFileName')
at System.ArgumentNullException.Throw(String paramName)
at System.ArgumentNullException.ThrowIfNull(Object argument, String paramName)
at System.Xml.XmlWriterSettings.CreateWriter(String outputFileName)
at System.Xml.Linq.XDocument.Save(String fileName, SaveOptions options)There was a problem hiding this comment.
this.File will never be null (it's a [Required] property, so MSBuild will show an error before we get to this point).
I could change it to var file = this.File!.ItemSpec;, although the final IL is the same.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 170 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
No description provided.