New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null for CGColorSpace.CreatePattern #20294

Merged

rolfbjarne merged 1 commit into xamarin:main from snechaev:main

Mar 13, 2024

Contributor

snechaev commented Mar 12, 2024

Per Apple docs for the CGColorSpaceCreatePattern(CGColorSpaceRef baseSpace), the baseSpace should be null when creating the color pattern. So, allow null here.

Fixes #20293


          Allow null for CGColorSpace.CreatePattern

Per Apple docs for the `CGColorSpaceCreatePattern(CGColorSpaceRef baseSpace)`, the `baseSpace` _should_ be null when creating the color pattern. So, allow `null` here.

Fixes #20293

Member

mandel-macaque commented Mar 12, 2024

/azp run

mandel-macaque approved these changes

View reviewed changes

mandel-macaque added the community label

azure-pipelines bot commented Mar 12, 2024

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator

vs-mobiletools-engineering-service2 commented Mar 12, 2024

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Mar 12, 2024

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Mar 12, 2024

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Mar 12, 2024

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Mar 12, 2024

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Mar 12, 2024

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 3383619ce8eea842854a686af72cbf959166be1c [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Mar 12, 2024

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 3383619ce8eea842854a686af72cbf959166be1c [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Mar 13, 2024

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 170 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 3383619ce8eea842854a686af72cbf959166be1c [PR build]

rolfbjarne approved these changes

View reviewed changes

rolfbjarne merged commit 5913110 into xamarin:main

60 checks passed

Member

rolfbjarne commented Mar 13, 2024

/sudo backport release/8.0.1xx-xcode15.1

Collaborator

vs-mobiletools-engineering-service2 commented Mar 13, 2024

Backport Job to branch release/8.0.1xx-xcode15.1 Created! The magic is happening here

vs-mobiletools-engineering-service2 mentioned this pull request

[release/8.0.1xx-xcode15.1] Allow null for CGColorSpace.CreatePattern #20297

Merged

Collaborator

vs-mobiletools-engineering-service2 commented Mar 13, 2024

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9235260 for more details.

rolfbjarne pushed a commit that referenced this pull request


          [release/8.0.1xx-xcode15.1] Allow null for CGColorSpace.CreatePattern (…

8094fb0

…#20297)

Per Apple docs for the `CGColorSpaceCreatePattern(CGColorSpaceRef baseSpace)`, the `baseSpace` _should_ be null when creating the color pattern. So, allow `null` here.

Fixes #20293

Backport of #20294

---------

Co-authored-by: Sergey Nechaev <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels