Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msbuild] Disable stripping symbols by default for Debug builds #20308

Merged
merged 2 commits into from
Mar 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/configuration-properties.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ There are a number of properties that are contingent upon the configuration sett
|-------------------------- |------------------- |--------------------------------------- |
| CodesignDisableTimestamp | true | |
| DebuggerSupport | true | |
| NoSymbolStrip | true | |
| RuntimeIdentifiers | maccatalyst-x64 | TargetFramework == netx.x-maccatalyst |
| RuntimeIdentifiers | osx-x64 | TargetFramework == netx.x-macos |
| UseSystemResourceKeys | false | |
2 changes: 2 additions & 0 deletions msbuild/Xamarin.Shared/Xamarin.Shared.props
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,8 @@ Copyright (C) 2020 Microsoft. All rights reserved.
<!-- Xamarin.Mac never had an equivalent for MtouchNoSymbolStrip and was never stripped, except when using NativeAOT -> true -->
<!-- default to 'false' -->
<NoSymbolStrip Condition="'$(NoSymbolStrip)' == '' And '$(_PlatformName)' != 'macOS'">$(MtouchNoSymbolStrip)</NoSymbolStrip>
<!-- Disable stripping for Debug builds by default -->
<NoSymbolStrip Condition="'$(NoSymbolStrip)' == '' And '$(Configuration)' == 'Debug'">true</NoSymbolStrip>
<NoSymbolStrip Condition="'$(NoSymbolStrip)' == '' And ('$(_PlatformName)' == 'macOS' Or '$(_PlatformName)' == 'MacCatalyst') And '$(_UseNativeAot)' != 'true'">true</NoSymbolStrip>
<!-- Disable stripping for simulator builds by default -->
<NoSymbolStrip Condition="'$(NoSymbolStrip)' == '' And ('$(_PlatformName)' == 'iOS' Or '$(_PlatformName)' == 'tvOS' Or '$(_PlatformName)' == 'watchOS') And '$(ComputedPlatform)' != 'iPhone'">true</NoSymbolStrip>
Expand Down
Loading