-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bgen] Provide correct initialization for AudioBuffers. #20356
[bgen] Provide correct initialization for AudioBuffers. #20356
Conversation
Fixes this warning: The type AudioToolbox.AudioBuffers does not have a constructor that takes two (ObjCRuntime.NativeHandle, bool) arguments but a constructor that takes two (System.IntPtr, bool) parameters was found (and will be used instead). It's highly recommended to change the signature of the (System.IntPtr, bool) constructor to be (ObjCRuntime.NativeHandle, bool). which comes from here: at ObjCRuntime.Runtime.GetIntPtr_BoolConstructor(Type type) in xamarin-macios/src/ObjCRuntime/Runtime.cs:line 1754 at ObjCRuntime.Runtime.ConstructINativeObject[AudioBuffers](IntPtr ptr, Boolean owns, Type type, MissingCtorResolution missingCtorResolution, IntPtr sel, RuntimeMethodHandle method_handle) in xamarin-macios/src/ObjCRuntime/Runtime.cs:line 1607 at ObjCRuntime.Runtime.GetINativeObject[AudioBuffers](IntPtr ptr, Boolean forced_type, Type implementation, Boolean owns, IntPtr sel, RuntimeMethodHandle method_handle) in xamarin-macios/src/ObjCRuntime/Runtime.cs:line 2118 at ObjCRuntime.Runtime.GetINativeObject[AudioBuffers](IntPtr ptr, Boolean forced_type, Type implementation, Boolean owns) in xamarin-macios/src/ObjCRuntime/Runtime.cs:line 2062 at ObjCRuntime.Runtime.GetINativeObject[AudioBuffers](IntPtr ptr, Boolean forced_type, Boolean owns) in xamarin-macios/src/ObjCRuntime/Runtime.cs:line 2057 at ObjCRuntime.Runtime.GetINativeObject[AudioBuffers](IntPtr ptr, Boolean owns) in xamarin-macios/src/ObjCRuntime/Runtime.cs:line 2052 at ObjCRuntime.Trampolines.SDAVAudioSourceNodeRenderHandler.Invoke(IntPtr block, Byte* isSilence, AudioTimeStamp* timestamp, UInt32 frameCount, NativeHandle* outputData) in xamarin-macios/src/build/dotnet/ios/generated-sources/ObjCRuntime/Trampolines.g.cs:line 526
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 170 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
Fixes this warning:
which comes from here: