Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Fix dependencies for Microsoft.<platform>.Sdk.DefaultItems.props. #20478

Merged
merged 1 commit into from
Apr 23, 2024

Commits on Apr 22, 2024

  1. [dotnet] Fix dependencies for Microsoft.<platform>.Sdk.DefaultItems.p…

    …rops.
    
    Make sure Microsoft.<platform>.Sdk.DefaultItems.props is rebuilt if the
    current hash changes.
    
    This fixes a local rebuild issue, where we'd rebuild
    Microsoft.\<platform\>.Sdk.Versions.props, but not
    Microsoft.\<platform\>.Sdk.DefaultItems.props.
    
    A build failure like this would thus result:
    
        tools/msbuild/iOS/Xamarin.Shared.targets(606,3): error : A bundle identifier is required. Either add an 'ApplicationId' property in the project file, or add a 'CFBundleIdentifier' entry in the project's Info.plist file.
    
    because:
    
    * We store the current git hash in both of the files mentioned above.
    * We only include default items in a build if the git hashes match.
    * Since the files weren't both rebuilt, they'd contain different hashes, and
      thus we wouldn't include Info.plist in the build, leading to the build
      error.
    rolfbjarne committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8a2ad5e View commit details
    Browse the repository at this point in the history