Add MHD module into main repository #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modi cmakelist in src and add post_vtk to ensure everything works
merge MHD module to the incompact3d, add a new example OTV2D, passed …
BC-TGV for both TGV and OT-MHD cases
mathrack
requested changes
Apr 17, 2024
mathrack
reviewed
Apr 17, 2024
mathrack
reviewed
Apr 17, 2024
mathrack
reviewed
Apr 17, 2024
mathrack
reviewed
Apr 17, 2024
mathrack
reviewed
Apr 17, 2024
mathrack
reviewed
Apr 17, 2024
mathrack
reviewed
Apr 17, 2024
|
All unnecessary code has been removed. |
mathrack
previously requested changes
Apr 18, 2024
mathrack
reviewed
Apr 18, 2024
slaizet
approved these changes
Apr 18, 2024
|
We should merge #267 first then this PR. I have rebased the present PR on top of the PR removing kind-specific functions |
|
Ok I have merged #267. Sylvain still wanted some modifications on the MHD examples. Shall we merge and after do the changes once Jian gives the case with the channel? |
|
I think the PR can be merged, and a later PR will polish the cases... But we could wait as well for a finalized version of the mhd cases. |
|
I'll check with Jian when the channel case is ready. If takes few more days I'll merge and refactor the MHD examples in a dedicated PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.