Fix bug in forces.f90 and enable force calculation for sphere example. #281
Conversation
There was a problem hiding this comment.
The description of the PR claims there is a bug in the force.f90 file. But the PR is not changing the file force.f90.
This PR should focus on fixing the bug. Please keep the PR small and dedicated to one clear objective. Please open a dedicated PR to enable force calculation for sphere example.
The previous PR updating the force calculation was accepted but it contained a bug. Please provide results showing the current code is broken and will be fixed thanks to the present PR.
src/xcompact3d.f90
Outdated
| @@ -275,7 +275,7 @@ subroutine init_xcompact3d() | |||
| open(42,file='time_evol.dat',form='formatted') | |||
| endif | |||
| endif | |||
| if (itype==5) then | |||
| if (iforces==1) then | |||
There was a problem hiding this comment.
The statement used to close the file unit 38 should also be modified. See https://github.com/xcompact3d/Incompact3d/blob/master/src/xcompact3d.f90#L312
There was a problem hiding this comment.
Hello,
Sorry for mixing two changes in one PR. I will open a dedicated PR for the sphere example. Also regarding the bug in the force.f90 file, if you refer to my original commit in the PR #269, there was minus sign infront of the xmom and ymom terms which got missing after the review commits from your side. Can you please check once again ? I have been using the my local version instead of the latest commit all this time, so didn't realize it. But few days back, I tried it and got negative drag and lift coeffficient for the sphere problem due to the missing minus sign.
Thanks,
Gaurav
There was a problem hiding this comment.
For now I will retract commits which retract all the commits except the forces-bug-fix. After the merging of this PR will open another PR for that.
There was a problem hiding this comment.
Hello, Sorry for mixing two changes in one PR. I will open a dedicated PR for the sphere example. Also regarding the bug in the force.f90 file, if you refer to my original commit in the PR #269, there was minus sign infront of the
xmomandymomterms which got missing after the review commits from your side. Can you please check once again ? I have been using the my local version instead of the latest commit all this time, so didn't realize it. But few days back, I tried it and got negative drag and lift coeffficient for the sphere problem due to the missing minus sign.Thanks, Gaurav
Hello, I am not sure to understand what you are talking about. The commit history of the code is public. Feel free to point to a specific modification in a specific commit.
There was a problem hiding this comment.
Sorry, I had mistaken about the minus sign being missing in the previous commits. I will revert all the commits and make a new commit with the bug fixed and results. Sorry for the confusion ! :)
Hello,
There is a small bug in the force.f90 file
Incompact3d/src/forces.f90
Line 905 in 2c7be99
Incompact3d/src/forces.f90
Line 906 in 2c7be99
The negative sign before
xmomandymomwas missing.Also, I have made modifications to enable force calcualtion in the sandbox mode if
iforces=1for immersed bodes using the subroutines inforces.f90. There are two separate.i3dfiles inexamples/Sphere. The filegen.i3dis used to generate the necessary files for sandbox mode and theinput.i3dis used for actual simulation. As xcompact3d-toolbox doesn't recognize the parametersiforcesand other force calculation parameters.