Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #552 #561

Merged
merged 2 commits into from
Jul 28, 2024
Merged

Fix #552 #561

merged 2 commits into from
Jul 28, 2024

Conversation

nwlandry
Copy link
Collaborator

This fixes #552. I can't create an example where the prior implementation will create issues (there's a weird overlap of issues which leads to the correct behavior), but I think that this is more explainable.

@nwlandry nwlandry requested a review from leotrs July 11, 2024 15:26
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (bc90a38) to head (340162f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   92.51%   92.51%           
=======================================
  Files          59       59           
  Lines        4393     4393           
=======================================
  Hits         4064     4064           
  Misses        329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nwlandry
Copy link
Collaborator Author

@leotrs --- is this something you're able to review? (Same question for #562)

@nwlandry nwlandry requested review from maximelucas and removed request for leotrs July 22, 2024 20:26
@nwlandry nwlandry merged commit 3e2c301 into main Jul 28, 2024
24 checks passed
@nwlandry nwlandry deleted the fix-552 branch July 28, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible error in stats
2 participants