Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlines in XML tags breaks appstreamcli validate #638

Open
hwittenborn opened this issue Jun 22, 2024 · 0 comments
Open

Newlines in XML tags breaks appstreamcli validate #638

hwittenborn opened this issue Jun 22, 2024 · 0 comments

Comments

@hwittenborn
Copy link

In my project, I have a MetaInfo file that gets automatically generated through BeautifulSoup. BeautifulSoup is outputting newlines in certain elements, and this appears to be breaking appstreamcli validate:

I: com.hunterwittenborn.Celeste:4: cid-maybe-not-rdns
     
             com.hunterwittenborn.Celeste
         
E: com.hunterwittenborn.Celeste:4: cid-invalid-character
     
             com.hunterwittenborn.Celeste
         : '
     '
E: com.hunterwittenborn.Celeste:4: cid-invalid-character
     
             com.hunterwittenborn.Celeste
         : ' '
I: com.hunterwittenborn.Celeste:10: developer-name-tag-deprecated
E: com.hunterwittenborn.Celeste:16: metadata-license-invalid 
        CC0-1.0
    
W: com.hunterwittenborn.Celeste:19: spdx-license-unknown GPL-3.0+
I: com.hunterwittenborn.Celeste:~: developer-info-missing

✘ Validation failed: errors: 3, warnings: 1, infos: 3, pedantic: 1

Removing the newlines on the tags for id, metadata_license, and project_license fixes the issue. Using other XML parsing tools doesn't include the newlines that appear to be causing the issue here, so I'm assuming such shouldn't be happening.

I found the issue when using flatpak-builder-lint, but it looks like they recommended filing an issue here.

hwittenborn added a commit to hwittenborn/celeste that referenced this issue Jun 22, 2024
Using a workaround until ximion/appstream#638 is figured out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant