Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghostrider ignores Environmnent Variables in config.json #2771

Closed
becgm opened this issue Dec 2, 2021 · 5 comments
Closed

Ghostrider ignores Environmnent Variables in config.json #2771

becgm opened this issue Dec 2, 2021 · 5 comments
Labels
bug
Milestone
v6

Comments

@becgm
Copy link

becgm commented Dec 2, 2021

When ghostrider algorithm is used the enviroment variables in config.json are not expanded.

When running randomx the correct worker ID is showed at pool's interface but when running ghostrider the worker is showed as ${HOSTNAME}.

The worker ID is configured at user's variable:
"user": "XxXxXxXxXxXxXx.${HOSTNAME}"
@Spudz76
Copy link
Contributor

Spudz76 commented Dec 2, 2021

Wasn't aware that ever worked.

@Spudz76
Copy link
Contributor

Spudz76 commented Dec 2, 2021

Okay, definitely works, and is wired globally in setPool() which is called regardless of algorithm.

@becgm
Copy link
Author

becgm commented Dec 2, 2021

Pool still shows ${HOSTNAME} and it cannot be a bug at pool's interface since this string is sent by the xmrig client.

@xmrig xmrig added the bug label Dec 2, 2021
@xmrig xmrig added this to the v6 milestone Dec 2, 2021
xmrig added a commit that referenced this issue Dec 2, 2021
@xmrig
#2771 Fixed environment variables support in EthStratumClient.
81b18c0
@xmrig
Copy link
Owner

xmrig commented Dec 2, 2021

Fixed in dev branch.
Thank you.

@Spudz76
Copy link
Contributor

Spudz76 commented Dec 2, 2021

Oops I forgot GR hides under the EthStratum umbrella.

Jhobean added a commit to Jhobean/xmrig that referenced this issue Dec 2, 2021
@Jhobean @xmrig @SChernykh
Merge actual branch (#1)
cf522d5 
* v6.16.2-dev

* VAES crash fixes

* Explicitly use QueryPerformanceCounter() on Windows

* Refactored Chrono::highResolutionMSecs()

Improved precision

* Compiler fix

* Updated changelog and GhostRider readme

* GhostRider benchmark: added 20 more possible rounds

* Compilationn fixes

* xmrig#2771 Fixed environment variables support in EthStratumClient.

* Update CHANGELOG.md

* v6.16.2

Co-authored-by: XMRig <[email protected]>
Co-authored-by: SChernykh <[email protected]>
@xmrig xmrig closed this as completed Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v6
Development

No branches or pull requests
3 participants
@Spudz76 @xmrig @becgm