Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv: fix performance issue #1889

Merged
merged 1 commit into from Oct 13, 2020
Merged

uv: fix performance issue #1889

merged 1 commit into from Oct 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 12, 2020

unix implementation of uv_async_t has been wasting cpu cycles for nothing since 1.29.0 release
implement efficient callback scheduling for linux

unix implementation of uv_async_t has been wasting cpu cycles for nothing since 1.29.0 release
implement efficient callback scheduling for linux
@ghost
Copy link
Author

ghost commented Oct 12, 2020

libuv/libuv#2231
The source of performance drop and it likely will not be reverted in libuv upstream.

@xmrig xmrig added this to the v6 milestone Oct 12, 2020
@xmrig
Copy link
Owner

xmrig commented Oct 12, 2020

Looks good, but need some time for review.
Thank you.

src/base/io/Async.cpp Show resolved Hide resolved
@xmrig xmrig merged commit 9fcc542 into xmrig:dev Oct 13, 2020
@ghost ghost deleted the fix_uv_issue branch October 13, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants