-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
websocket channels #18
base: master
Are you sure you want to change the base?
Conversation
Things planed in my mind:
|
Thanks a lot for the contributions. It will be helpful as is for now. Before merging anything, I would like to have things in separate pull requests though. As far as I understood, I see several contributions:
Also, |
@xoolive I know it's not a good practice to create such a meta PR. Make it hard to review. I worked on this locally to explore different ideas. Let's keep it here as it does help in some cases, and for communication. You have made a good summary. I will split it into small ones. As for the http library, I have no preference. I choose Axum simply because I know a little more about it. Anyway, Challenge accepted. |
6592db7
to
f24e244
Compare
0628454
to
1c7cf5b
Compare
3f033f6
to
1fbbbea
Compare
@emctoo if that's ok with you, I would like to merge that one too. The idea would be to only have the data distributed in websockets for now (so that it works with tangram), and keep the data source as websocket format, as we discussed this morning for a separate PR. |
c071186
to
4b9f6a0
Compare
22c5e1f
to
3127a57
Compare
@emctoo Should we keep this open or close it? |
No description provided.