Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websocket channels #18

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

websocket channels #18

wants to merge 2 commits into from

Conversation

emctoo
Copy link
Contributor

@emctoo emctoo commented Jun 19, 2024

No description provided.

@emctoo emctoo mentioned this pull request Jun 19, 2024
@emctoo
Copy link
Contributor Author

emctoo commented Jun 19, 2024

Things planed in my mind:

  • flake reads version from Cargo.toml
  • options for Websocket host and port
  • maybe a feature flag for Websocket support

@xoolive
Copy link
Owner

xoolive commented Jun 19, 2024

Thanks a lot for the contributions. It will be helpful as is for now.

Before merging anything, I would like to have things in separate pull requests though.

As far as I understood, I see several contributions:

  • the logging possibilities
  • the flake support, previously in Add nix flake support #6 (we could reopen it there)
  • the web socket for serving decoded messages;
  • the web socket for getting a binary feed

Also, jet1090 already uses one web server library called warp which supports web sockets, so I would rather not add another similar library Axum (then we don't need to think too much about features 😉)

@emctoo
Copy link
Contributor Author

emctoo commented Jun 20, 2024

@xoolive I know it's not a good practice to create such a meta PR. Make it hard to review.

I worked on this locally to explore different ideas. Let's keep it here as it does help in some cases, and for communication.

You have made a good summary. I will split it into small ones. As for the http library, I have no preference. I choose Axum simply because I know a little more about it. Anyway, Challenge accepted.

@emctoo emctoo force-pushed the channel branch 2 times, most recently from 6592db7 to f24e244 Compare June 23, 2024 10:40
@xoolive xoolive force-pushed the channel branch 2 times, most recently from 0628454 to 1c7cf5b Compare June 24, 2024 13:05
@xoolive xoolive changed the title Websocket Channels using Axum websocket channels Jun 26, 2024
@emctoo emctoo force-pushed the channel branch 3 times, most recently from 3f033f6 to 1fbbbea Compare July 30, 2024 02:55
@xoolive
Copy link
Owner

xoolive commented Aug 8, 2024

@emctoo if that's ok with you, I would like to merge that one too. The idea would be to only have the data distributed in websockets for now (so that it works with tangram), and keep the data source as websocket format, as we discussed this morning for a separate PR.

@xoolive
Copy link
Owner

xoolive commented Sep 10, 2024

@emctoo Should we keep this open or close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants