Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

[minor] support ZTS JWT #49

Merged
merged 15 commits into from
Apr 8, 2020
Merged

[minor] support ZTS JWT #49

merged 15 commits into from
Apr 8, 2020

Conversation

WindzCUHK
Copy link
Contributor

@WindzCUHK WindzCUHK commented Mar 31, 2020

TODO

  • add config for new authorizer interface
  • extract token from request
  • support both access token and role token (co-exist)
  • update go.mod

note

  1. must set CA to enable cert bound access token, if ca != "" => t.ClientAuth = tls.RequireAndVerifyClientCert

fixed issues

@WindzCUHK WindzCUHK changed the title [WIP] add JWT support add JWT support Apr 2, 2020
@WindzCUHK WindzCUHK changed the title add JWT support support ZTS JWT Apr 2, 2020
@WindzCUHK WindzCUHK changed the title support ZTS JWT [minor] support ZTS JWT Apr 7, 2020
usecase/authz_proxyd.go Show resolved Hide resolved
service/authorizerd_mock.go Outdated Show resolved Hide resolved
handler/handler_test.go Outdated Show resolved Hide resolved
handler/handler_test.go Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
handler/handler_test.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #49 into master will increase coverage by 0.26%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   86.24%   86.50%   +0.26%     
==========================================
  Files          14       14              
  Lines         589      630      +41     
==========================================
+ Hits          508      545      +37     
- Misses         71       75       +4     
  Partials       10       10              
Impacted Files Coverage Δ
config/config.go 100.00% <ø> (ø)
service/authorizerd_mock.go 0.00% <0.00%> (ø)
handler/handler.go 92.85% <100.00%> (+0.26%) ⬆️
handler/transport.go 100.00% <100.00%> (ø)
usecase/authz_proxyd.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c6a4ee...d6036e6. Read the comment docs.

Copy link
Contributor

@kyfujisa kyfujisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WindzCUHK WindzCUHK merged commit c8bcdd6 into master Apr 8, 2020
@WindzCUHK WindzCUHK deleted the add-access-token branch April 8, 2020 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config for "Bot from GolangCI" to ignore glg error handling
4 participants