support disabling ssl validation in openapi2jsonschema.py #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Any chance to add an acceptance tests to demonstrate that this works? 🙏 |
Sure, added and tested. Added an additional commit which speeds up docker build of bats image. |
|
Mhhh I guess to properly test this we'd need a host with a broken or self-signed certificate... I'm not going to use this, if it works for you I'm ok to merge it :) |
|
Yes, it works for me, thanks) I didn't change the script's behaviour with respect to certificates usage, only allowed to disable CA cert usage when accessing kubernetes yaml CRDs using https. Without this, the script fails on MAC and requires to modify it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157
not the best implementation, but the pr has the minimal changes required in order to run this script on MAC without an issue. If the pr is approved, will edit the README as well