Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing output formats in error message #213

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Jun 14, 2023

  • Add missing 'junit' and 'pretty' output formats.
  • Use quotes vs. backticks around command name

Note:

  • I can revert the change removing the backticks, or, if you prefer, I could bold it, which might look better?
  • I don't know if you want output or -output vs outputFormat? The user typically invokes the format using -output, I think.
  • Could also make this a data structure and try to DRY it up a little, to make the error self-update?

- Add missing 'junit' and 'pretty' output formats.
- Use quotes vs. backticks around command name
@wyardley
Copy link
Contributor Author

@yannh let me know if this looks right to you

@yannh yannh merged commit 71fd5f8 into yannh:master Jun 14, 2023
@yannh
Copy link
Owner

yannh commented Jun 14, 2023

Thanks for the patch ❤️ !

@wyardley wyardley deleted the wyardley/update/outputformat-error branch June 14, 2023 20:44
yannh pushed a commit to levenleven/kubeconform that referenced this pull request Jul 9, 2023
- Add missing 'junit' and 'pretty' output formats.
- Use quotes vs. backticks around command name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants