Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip resources using the GVK notation #92

Merged
merged 2 commits into from
Oct 16, 2022

Conversation

atosatto
Copy link
Contributor

@atosatto atosatto commented Jan 18, 2022

This is improving the skip or reject functionality allowing to provide the full GroupVersionKind encoding for resources to be skipped.

The functionality is useful in scenarios in which specific versions of certain resources should always be rejected and/or to allow more fine-grained control of the skip logic.

Unlike the GKV encoding implemented in the upstream Kubernetes project, the APIVersion and Kind fields are separated by / to allow the concatenation of multiple arguments by ,.

@yannh
Copy link
Owner

yannh commented Apr 6, 2022

Hey @atosatto , sorry for being a bit slow to follow with this PR. Is this linked to #84 ? I got thinking about the tests and now realise a good part of the diff is just reformatting 🙈

Thanks a lot for your contribution ❤️

Could you update the Readme and usage guidelines to make it clear how this would change the usage? 🙏 Thanks!

@yannh yannh merged commit d8e348a into yannh:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants