Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplements yarn explain peer-requirements #5834

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Oct 24, 2023

What's the problem this PR addresses?

I didn't update the yarn explain peer-requirements when I refactored the peer dependency warnings to report aggregates rather than independent entries. As a result, the reported hash doesn't work.

Fixes #5826

How did you fix it?

I reimplemented yarn explain peer-requirements to take those warnings into account. I also updated the output to use a more natural language which might help better understand the situation:

Screenshot 2023-10-24 at 12 04 20

Note that I temporarily removed support for calling yarn explain peer-requirements on missing peer dependencies, as I'd like to take another look at those warnings in general (I noticed they aren't aggregated, but they probably should be too). Since they are fairly easy to understand by themselves, I don't feel like this is a significant regression.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 70b7c10 into master Oct 24, 2023
16 checks passed
@arcanis arcanis deleted the mael/explain-peer-requirements branch October 24, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: Incorrect peer dependency violation reported
1 participant