Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow modules prefixed with node: #6355

Closed
wants to merge 2 commits into from

Conversation

jkowalleck
Copy link
Contributor

What's the problem this PR addresses?

in nodejs, it is allowed to import builtins by prefixing them with node:.
This PR enables this for yarn plugins.

fixes #5417

How did you fix it?

Currently, all builtin modules are added to an import map.
I've added all these same modules to the import map a second time, but all with the prefix node:.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

Signed-off-by: Jan Kowalleck <[email protected]>
Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkowalleck
Copy link
Contributor Author

closed, in favor of #5997

@jkowalleck jkowalleck closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: node: protocol is not supported in plugin factory require
2 participants