Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sublists #67

Open
KonoromiHimaries opened this issue Jun 3, 2018 · 16 comments
Open

sublists #67

KonoromiHimaries opened this issue Jun 3, 2018 · 16 comments

Comments

@KonoromiHimaries
Copy link
Contributor

KonoromiHimaries commented Jun 3, 2018

do you can divide the webannoyances list into a sublists

example. you can based on the model of polishsubfilters
https://github.com/KonoromiHimaries/PolishSubFilters/tree/master/internal-filters
or polishannoyancefilters model
https://github.com/PolishFiltersTeam/PolishAnnoyanceFilters/tree/master/PPB

potential benefits

  • fast loading of the list
  • increased editing convenience
  • anyone will be able to subscribe to one sublist without having to subscribe to all webannoyances filters
@yourduskquibbles
Copy link
Owner

I would ultimately like to do this but need to research how some of the other lists maintainers manage this before doing so.

It's also a time commitment that I don't have right now to implement immediately.

@hawkeye116477
Copy link

You can just divide it into few files, then use #include directives in big main filterlist, which uBO supports to include smaller lists. Of course you can also do that just like I created templates file, made some scripts to merge all, but I think that in that case it's not needed, cuz you support only uBO, but maybe autosorting and autoversioning will be useful 😄

yourduskquibbles added a commit that referenced this issue Jul 27, 2018
yourduskquibbles added a commit that referenced this issue Jul 27, 2018
* Test of subfilter lists

* Update ultralist.txt

* Update ultralist.txt

Relates to #67
yourduskquibbles added a commit that referenced this issue Jul 27, 2018
yourduskquibbles added a commit that referenced this issue Jul 28, 2018
yourduskquibbles added a commit that referenced this issue Aug 1, 2018
yourduskquibbles added a commit that referenced this issue Aug 1, 2018
@yourduskquibbles
Copy link
Owner

yourduskquibbles commented Jan 21, 2019

Forgot this was still open, thanks for closing @KonoromiHimaries

yourduskquibbles added a commit that referenced this issue Nov 18, 2019
yourduskquibbles added a commit that referenced this issue Nov 18, 2019
…bscription

Add CSS Style Companion Filter List - this list will be for elements that should be removed and *only* loaded when either ultralist.txt (and all corresponding sublists) or *just* css_style_filters.txt are enabled.

Related #67
yourduskquibbles added a commit that referenced this issue Nov 18, 2019
…bscription

Add CSS Style Companion Filter List - this list will be for elements that should be removed and *only* loaded when either ultralist.txt (and all corresponding sublists) or *just* css_style_filters.txt are enabled.

Related #67
yourduskquibbles added a commit that referenced this issue Nov 18, 2019
yourduskquibbles added a commit that referenced this issue Nov 18, 2019
Delete css_style_companion_filters.txt

Related #67
yourduskquibbles added a commit that referenced this issue Nov 18, 2019
yourduskquibbles added a commit that referenced this issue Dec 6, 2019
Sublist for filters related to empty advertising placeholders.

The intention with this sublist is to remove all of these currently existing filters from `utlralist.txt` so eventually `ultralist.txt` is ONLY a list that exists to subscribes to all sublists. This will allow the flexibility for users to only subscribe to certain features of ultralist.txt e.g. only remove newsletter & empty ad boxes but don't change any CSS elements like sticky headers. (e.g. don't subscribe to `css_style_filters.txt`

Relates to #67
yourduskquibbles added a commit that referenced this issue Dec 6, 2019
@yourduskquibbles
Copy link
Owner

yourduskquibbles commented Dec 6, 2019

Moving forward, I will be moving empty advertising filters into the ad_placeholders.txt sublist.

The long-term intention with ad_placeholders.txt sublist will be to remove all of these advertising filters from utlralist.txt so eventually ultralist.txt is ONLY a list that exists to subscribe to all Web Annoyances sublists.

This should allow the flexibility for users to only subscribe to certain features of Web Annoyances Ultralist e.g. users who only want to remove social buttons & empty ad boxes but don't want to change any CSS elements of a site like sticky headers or newsletter subscription requests (e.g. don't subscribe to css_style_filters.txt & newsletter_filters.txt)

This is also the reason behind recently creating css_companion_filters.txt sublist.

@yourduskquibbles
Copy link
Owner

Reopening to help others track maintenance progress of moving existing filters from ultralist.txt into various sublists.

yourduskquibbles added a commit that referenced this issue Jan 10, 2020
move ultralist.txt filters to sublists
Related #67
yourduskquibbles added a commit that referenced this issue Jan 20, 2020
…filters from ultralist.txt to sublist

Related #67
yourduskquibbles added a commit that referenced this issue Jan 22, 2020
…ilters from ultralist.txt to sublists

Related #67
yourduskquibbles added a commit that referenced this issue Feb 27, 2020
…investors.com,marieclaire.com,popularmechanics.com,roadandtrack.com,runnersworld.com,shondaland.com,si.com,townandcountrymag.com & move filters from ultralist.txt into sublists

Related #67
yourduskquibbles added a commit that referenced this issue Feb 28, 2020
Related #67
Move mariettatimes.com -> marthastewart.com from ultralist.txt to sublists
@RedDragonWebDesign
Copy link
Contributor

It might make sense to give cookie/gdpr filters their own sublist.

Also, I see a bunch of social filters in the generic sublist.

I'd be happy to submit a pull request for one or both of these if you're interested.

@liamengland1
Copy link
Contributor

Should paywall filters go in a separate list too? And what's the policy in this repo? Are all paywalls removed when possible?

@yourduskquibbles
Copy link
Owner

@GeneralKenobi1 I agree with splitting up cookie/gdpr filters - I can create a new sublist for that and I would be happy to accept a PR - Right now most of those filters would be in the modal_filters.txt list as well as generic_filters.txt

@llacb47 I prefer not to have a separate paywall sublist, the general policy for Web Annoyances Ultralist is to remove them if it's a soft paywall/warning that only requires modifying CSS or blocking a 1st or 3rd party script - no script injection workarounds or faking subscription status.

There are separate extensions users can use if they want to go that route, e.g. Bypass Paywalls Clean for Firefox & Bypass Paywalls Clean for Chrome or even something as simple as Cookie Auto Delete for Firefox & Cookie Auto Delete for Chrome

yourduskquibbles added a commit that referenced this issue Jun 24, 2020
@liamengland1
Copy link
Contributor

liamengland1 commented Jun 24, 2020

There's a paywall scriptlet bypass right here, are you going to remove it? :P https://github.com/yourduskquibbles/webannoyances/blob/master/ultralist.txt#L186

@yourduskquibbles
Copy link
Owner

@GeneralKenobi1 I just added a new cookie_filters.txt sublist and just seeded it with a few existing filters from the modal_filters.txt sublist. Feel free to submit PR's and THANK YOU in advance for any help!

@yourduskquibbles
Copy link
Owner

There's a paywall scriptlet bypass right here, are you going to remove it? :P https://github.com/yourduskquibbles/webannoyances/blob/master/ultralist.txt#L185

Looks like that is just removing a cosmetic DOM element, not injecting scripts or changing the page content that isn't already loaded in the DOM when a user navigates to the page?

@liamengland1
Copy link
Contributor

liamengland1 commented Jun 24, 2020

There's a paywall scriptlet bypass right here, are you going to remove it? :P https://github.com/yourduskquibbles/webannoyances/blob/master/ultralist.txt#L185

Looks like that is just removing a cosmetic DOM element, not injecting scripts or changing the page content that isn't already loaded in the DOM when a user navigates to the page?

bizjournals.com##+js(set-constant.js, __page__.isPremium, false)

I'm not saying you should remove it by the way, just saying this policy limits how much paywall bypassing can be done

@yourduskquibbles
Copy link
Owner

There's a paywall scriptlet bypass right here, are you going to remove it? :P https://github.com/yourduskquibbles/webannoyances/blob/master/ultralist.txt#L185

Looks like that is just removing a cosmetic DOM element, not injecting scripts or changing the page content that isn't already loaded in the DOM when a user navigates to the page?

bizjournals.com##+js(set-constant.js, __page__.isPremium, false)

I see you pointed to L186 in edit now, yes I will remove that, no need to create undue risk when other extensions exist. Probably added it a long time ago when I found the filter on reddit or something like that. Thanks for pointing out

@yourduskquibbles
Copy link
Owner

I'm not saying you should remove it by the way, just saying this policy limits how much paywall bypassing can be done

It's OK, it's not the intention or primary goal of this list to bypass paywalls so don't want to host that anyway and risk taking the whole project down.

yourduskquibbles added a commit that referenced this issue Jul 8, 2020
yourduskquibbles added a commit that referenced this issue Jul 14, 2020
…ew sublist called floating_filters.txt

Address: #231
Related: #67
yourduskquibbles added a commit that referenced this issue Aug 11, 2020
This sublist is to address display issues caused by CSS companion filters removing content that shouldn't be removed on adguard for iOS due to CSS style modifying filters not being loaded (iOS & Safari design constraint)

Related #67
yourduskquibbles added a commit that referenced this issue Aug 13, 2020
…ion_filters.txt

Change in list name to mirror the pre-parser directive nomenclature for the AdGuard iOS app

Related: #241
Related: #67
@cmnbhgt
Copy link

cmnbhgt commented Jun 29, 2024

You can just divide it into few files, then use #include directives in big main filterlist, which uBO supports to include smaller lists. Of course you can also do that just like I created templates file, made some scripts to merge all, but I think that in that case it's not needed, cuz you support only uBO, but maybe autosorting and autoversioning will be useful 😄

@hawkeye116477 What exactly do you mean by autosorting?

@hawkeye116477
Copy link

@hawkeye116477 What exactly do you mean by autosorting?

I mean that script will sort rules alphabetically. You can then set launching it through GitHub Actions for example twice per day, so it will be automatic process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants