Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md for further contributors #144

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

longfin
Copy link
Contributor

@longfin longfin commented Apr 15, 2024

This PR adds "Build & Run" section to introduce other contributors.

@rhea-so could you let me know a minimum version for nodejs and any other requirements if exists? (I'll amend it)

@rhea-so
Copy link
Contributor

rhea-so commented Apr 15, 2024

@longfin

Thank you for contribution!

Please follow .nvmrc file in root directory.

@rhea-so
Copy link
Contributor

rhea-so commented Apr 15, 2024

I think it would be better to make CONTRIBUTION.md.

@longfin longfin changed the title Add Build & Run section to README.md Add CONTRIBUTING.md for further contributors Apr 15, 2024
@longfin longfin marked this pull request as ready for review April 15, 2024 11:37
@longfin longfin requested a review from rhea-so as a code owner April 15, 2024 11:37
@longfin
Copy link
Contributor Author

longfin commented Apr 15, 2024

@rhea-so PTAL 🙏

Copy link
Contributor

@rhea-so rhea-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@rhea-so rhea-so merged commit 8fc234d into yurucam:main Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants