Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #78 - Add a Structurizr example #92

Merged
merged 10 commits into from
Mar 13, 2022

Conversation

arukiidou
Copy link
Contributor

@arukiidou arukiidou commented Mar 1, 2022

add structurizr example
resolves #78

resolves yuzutech/kroki#1150

@arukiidou arukiidou changed the title draft: Update main.js draft: Add a Structurizr example - refolved #78 Mar 1, 2022
@arukiidou arukiidou changed the title draft: Add a Structurizr example - refolved #78 Add a Structurizr example - refolved #78 Mar 1, 2022
@arukiidou arukiidou marked this pull request as ready for review March 1, 2022 13:27
@arukiidou arukiidou changed the title Add a Structurizr example - refolved #78 Add a Structurizr example - resolved #78 Mar 1, 2022
@arukiidou arukiidou changed the title Add a Structurizr example - resolved #78 resolves #78 - Add a Structurizr example Mar 1, 2022
@arukiidou arukiidou marked this pull request as draft March 3, 2022 15:03
@arukiidou
Copy link
Contributor Author

I didn't fix the view-key.

examples.html Outdated
}
</code></pre>
<div class="highlight">
<pre><code class="language-http">GET https://kroki.io/structurizr/svg/eNq1UEFOxDAMvPMKN0ckngASghewQpzdxtVGpHEUOxtWq_07aam62y4cmUsyEzszNhROnxKxIzjdQcXAljycYCIjslCCR4iUhAOY90rN5VW414KJdkdRGmrdRjC7mcOPYK6_HlGoxRhrY8dB0YVqZj6ohecYvetQHYebniXWwxPo3smUSpqmMeu685paVGxRaG32Oqu_uszpFp83QivQJx4Ag4WSnJKA8t_G83U-Do6KXBvJtJWXGoe-dLu8TSAXOp8twf1axqzs8chZwacb4xGXaf_JQPc0EFjqMXtdBj5_A1fGoBA=</code></pre>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add ?view-key=SoftwareSystem-Container (otherwise we get a random view)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added view-key (changed to other diagram examples, so view-key is different)

examples.html Outdated
<div class="highlight">
<pre><code class="language-http">GET https://kroki.io/structurizr/svg/eNq1UEFOxDAMvPMKN0ckngASghewQpzdxtVGpHEUOxtWq_07aam62y4cmUsyEzszNhROnxKxIzjdQcXAljycYCIjslCCR4iUhAOY90rN5VW414KJdkdRGmrdRjC7mcOPYK6_HlGoxRhrY8dB0YVqZj6ohecYvetQHYebniXWwxPo3smUSpqmMeu685paVGxRaG32Oqu_uszpFp83QivQJx4Ag4WSnJKA8t_G83U-Do6KXBvJtJWXGoe-dLu8TSAXOp8twf1axqzs8chZwacb4xGXaf_JQPc0EFjqMXtdBj5_A1fGoBA=</code></pre>
<button class="button is-small bd-copy"
data-clipboard-text="https://kroki.io/structurizr/svg/eNq1UEFOxDAMvPMKN0ckngASghewQpzdxtVGpHEUOxtWq_07aam62y4cmUsyEzszNhROnxKxIzjdQcXAljycYCIjslCCR4iUhAOY90rN5VW414KJdkdRGmrdRjC7mcOPYK6_HlGoxRhrY8dB0YVqZj6ohecYvetQHYebniXWwxPo3smUSpqmMeu685paVGxRaG32Oqu_uszpFp83QivQJx4Ag4WSnJKA8t_G83U-Do6KXBvJtJWXGoe-dLu8TSAXOp8twf1axqzs8chZwacb4xGXaf_JQPc0EFjqMXtdBj5_A1fGoBA="
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to add it here as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also added view-key (changed to other diagram examples, so view-key is different)

@ggrossetie
Copy link
Member

Thanks @arukiidou
I left one comment regarding the view-key but otherwise 👍🏻

- change: use big bank example To support other types of views
@arukiidou arukiidou marked this pull request as ready for review March 4, 2022 14:41
@arukiidou
Copy link
Contributor Author

arukiidou commented Mar 4, 2022

Thanks @arukiidou I left one comment regarding the view-key but otherwise 👍🏻

Sorry for the review. changes diagram examples(later support other types of views) .

If the previous diagram is better, I'll change it back

@ggrossetie
Copy link
Member

It looks good, thanks 👍🏻

@ggrossetie ggrossetie merged commit 4c4b47f into yuzutech:master Mar 13, 2022
@arukiidou
Copy link
Contributor Author

It looks good, thanks 👍🏻

Thank you for accepting my contribution, and your great project!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples for structurizr Add a Structurizr example
2 participants