Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ephemeral storage limit check not skipped when "kube-score/ignore": "… #450

Merged
merged 1 commit into from
Mar 27, 2022
Merged

Ephemeral storage limit check not skipped when "kube-score/ignore": "… #450

merged 1 commit into from
Mar 27, 2022

Conversation

kmarteaux
Copy link
Contributor

@kmarteaux kmarteaux commented Mar 25, 2022 •
edited
Loading

…container-resources" annotation is set #449

RELNOTE:  

Bugfix:  Container ephemeral storage tests did not honor "kube-score/ignore": "container-resources" annotation because the tests were implemented apart from the extant CPU and memory container tests.  Fix addresses this oversight by noting the "container-resources" annotation implies also ignoring the "container-ephemeral-storage-request-and-limit" tests.

zegl
zegl approved these changes Mar 27, 2022
View reviewed changes
Copy link
Owner

@zegl zegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 27, 2022

Build succeeded:

@bors bors bot merged commit 090a5ab into zegl:master Mar 27, 2022
@zegl zegl mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zegl zegl zegl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmarteaux @zegl