Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't transfer market creator fees if sender == receiver #1154

Closed
sea212 opened this issue Oct 18, 2023 · 1 comment · Fixed by #1156
Closed

Don't transfer market creator fees if sender == receiver #1154

sea212 opened this issue Oct 18, 2023 · 1 comment · Fixed by #1156
Assignees
@sea212
Labels
l:XS Solving this issue takes minutes p:medium Medium priority, this issue can wait but should be done fairly soon t:enhancement The issue described an enhancement

Comments

@sea212
Copy link
Member

sea212 commented Oct 18, 2023

See title
@sea212 sea212 added p:medium Medium priority, this issue can wait but should be done fairly soon t:enhancement The issue described an enhancement labels Oct 18, 2023
@sea212 sea212 added this to the v0.4.2 milestone Oct 18, 2023
@sea212 sea212 self-assigned this Oct 18, 2023
@sea212 sea212 changed the title Add market_id to MarketCreatorFee* events Don't transfer market creator fees if sender == receiver Oct 18, 2023
@sea212 sea212 added the l:XS Solving this issue takes minutes label Oct 18, 2023
@sea212 sea212 mentioned this issue Oct 20, 2023
Merged
@sea212 sea212 removed this from the v0.4.2 milestone Oct 25, 2023
@saboonikhil
Copy link
Member

saboonikhil commented Dec 13, 2023 •
edited
Loading

Post the fix, I don't find the BalancesTransferEvent on-chain. Is it also possible to stop emission of MarketCreatorFeesPaidEvent as seen here. This should help subsquid avoid looking into them altogether. Thanks!

Forgot my glasses!

@saboonikhil saboonikhil reopened this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sea212 sea212

Labels
l:XS Solving this issue takes minutes p:medium Medium priority, this issue can wait but should be done fairly soon t:enhancement The issue described an enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix market creator paying fees to himself zeitgeistpm/zeitgeist
2 participants
@sea212 @saboonikhil