Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix market creator paying fees to himself #1156

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Oct 20, 2023

What does it do?

See title

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

closes #1154

References

@sea212 sea212 added the s:review-needed The pull request requires reviews label Oct 20, 2023
@sea212 sea212 added this to the v0.4.2 milestone Oct 20, 2023
@sea212 sea212 self-assigned this Oct 20, 2023
@sea212 sea212 merged commit 6c466cd into main Oct 21, 2023
6 of 12 checks passed
@sea212 sea212 deleted the sea212-fix-market-creator-fee-self-payment branch October 21, 2023 13:47
@sea212 sea212 added s:accepted This pull request is ready for merge i:spec-changed ⚠️ Implies change in spec version and removed s:review-needed The pull request requires reviews labels Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i:spec-changed ⚠️ Implies change in spec version s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't transfer market creator fees if sender == receiver
2 participants