Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code owners #1017

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Add code owners #1017

merged 1 commit into from
Jun 14, 2023

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Jun 9, 2023

This PR adds code owners to this project. Code owners will be automatically selected as reviewers within PRs that modify parts of the project they own. Code owners are allowed to delegated their responsibility to review to someone else.

Initial code owners were determined by total involvement:

/node/ @sea212
/runtime/ @sea212
/zrml/authorized/ @Chralt98
/zrml/court/ @Chralt98
/zrml/global-disputes/ @Chralt98
/zrml/prediction-markets/ @maltekliemann
/zrml/rikiddo/ @sea212
/zrml/simple-disputes/ @Chralt98
/zrml/styx/ @yornaath
/zrml/swaps/ @maltekliemann

@sea212 sea212 added the s:review-needed The pull request requires reviews label Jun 9, 2023
@sea212 sea212 self-assigned this Jun 9, 2023
@maltekliemann
Copy link
Member

When someone with admin or owner permissions has enabled required reviews, they also can optionally require approval from a code owner before the author can merge a pull request in the repository. For more information, see "About protected branches." [https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners]

Should we enable this?

@sea212
Copy link
Member Author

sea212 commented Jun 9, 2023

When someone with admin or owner permissions has enabled required reviews, they also can optionally require approval from a code owner before the author can merge a pull request in the repository.
[...]

Should we enable this?

@maltekliemann I think this conflicts with the permission that the code owner can delegate the review, as the code owner will be forced to review by toggling this setting. I think it is sufficient that the code owner automatically gets notified as a reviewer in any PR, as the code owner will be aware when changes to parts of the code the code owners owns are requested to be applied. In case anyone just "wildly" merges PRs disregarding the code owners opinion at all, this will be definitely uncovered and discussed.

@codecov-commenter
Copy link

Codecov Report

Merging #1017 (544ce6f) into main (13f4e67) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files          93       93           
  Lines       21177    21177           
=======================================
  Hits        20004    20004           
  Misses       1173     1173           
Flag Coverage Δ
tests 94.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@yornaath yornaath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Jun 14, 2023
@sea212 sea212 merged commit 31d1700 into main Jun 14, 2023
11 checks passed
@sea212 sea212 deleted the sea212-add-codeowners branch June 14, 2023 18:54
@sea212 sea212 added this to the v0.3.9 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants