-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code owners #1017
Add code owners #1017
Conversation
Should we enable this? |
@maltekliemann I think this conflicts with the permission that the code owner can delegate the review, as the code owner will be forced to review by toggling this setting. I think it is sufficient that the code owner automatically gets notified as a reviewer in any PR, as the code owner will be aware when changes to parts of the code the code owners owns are requested to be applied. In case anyone just "wildly" merges PRs disregarding the code owners opinion at all, this will be definitely uncovered and discussed. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1017 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 93 93
Lines 21177 21177
=======================================
Hits 20004 20004
Misses 1173 1173
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
This PR adds code owners to this project. Code owners will be automatically selected as reviewers within PRs that modify parts of the project they own. Code owners are allowed to delegated their responsibility to review to someone else.
Initial code owners were determined by total involvement: