Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove admin_destroy_market #1145

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Remove admin_destroy_market #1145

merged 1 commit into from
Oct 17, 2023

Conversation

maltekliemann
Copy link
Member

What does it do?

Removes admin_destroy_market and relevant tests.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@maltekliemann maltekliemann self-assigned this Oct 13, 2023
@maltekliemann maltekliemann added this to the v0.4.2 milestone Oct 13, 2023
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews i:transactions-changed ⚠️ Implies change in transaction version labels Oct 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3d9bbff) 93.54% compared to head (bee060e) 93.38%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
- Coverage   93.54%   93.38%   -0.17%     
==========================================
  Files         114      114              
  Lines       32558    31692     -866     
==========================================
- Hits        30458    29594     -864     
+ Misses       2100     2098       -2     
Flag Coverage Δ
tests 93.38% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
zrml/prediction-markets/src/benchmarks.rs 99.64% <ø> (-0.04%) ⬇️
zrml/prediction-markets/src/lib.rs 83.95% <ø> (-1.00%) ⬇️
zrml/prediction-markets/src/tests.rs 99.49% <ø> (+0.07%) ⬆️
zrml/prediction-markets/src/weights.rs 96.68% <ø> (-0.31%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea212 sea212 self-requested a review October 17, 2023 13:12
@sea212 sea212 merged commit f4983a3 into main Oct 17, 2023
16 of 23 checks passed
@sea212 sea212 deleted the mkl-remove-admin-destroy-market branch October 17, 2023 15:27
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i:transactions-changed ⚠️ Implies change in transaction version s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants