Include system remarks to help testing process #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chralt98
added
s:review-needed
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 114 114
Lines 32558 32558
=======================================
Hits 30458 30458
Misses 2100 2100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sea212
reviewed
Oct 16, 2023
sea212
added
s:in-progress
Chralt98
added
s:review-needed
Chralt98
approved these changes
Oct 17, 2023
sea212
approved these changes
Oct 17, 2023
sea212
added
s:accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds
remarkandremark_with_eventto the available pallet calls in battery station. This would be helpful for developers who want to test their smart contract setup with Zeitgeist Battery Station, but don't want to immediately implement any of the more complex extrinsics that are currently available (to ensure that their setup works, all other things being equal).I am one such developer