Remove unchecked modulo operations from production

[maltekliemann]

What does it do?

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

[sea212]

Seems good to me, however there are still two occurrences of unchecked modulo in production code:

zeitgeist/zrml/court/src/lib.rs

Line 1416 in 33503db

debug_assert!((max % min_juror_stake).is_zero(), "This is ensured by the caller.");

zeitgeist/zrml/court/src/lib.rs

Lines 1795 to 1798 in 33503db

	debug_assert!(
	(total_unconsumed % min_juror_stake).is_zero(),
	"Remainders are being cut in the above for loop."
	);

[maltekliemann]

Okay, those are in debug_assert statements though.

[sea212]

Right, but as far as I can tell the node will panic due to the modulo by zero instead of the assertion. Fine to leave like that from my perspective though, as the node would crash anyways (another topic).

[maltekliemann]

The problem is that it's not easy to have really good error handling without changing the return value of the function, We can just remove the debug_assert statement?

[sea212]

I think this would be a good example for the unreachable_non_terminating macro plus a test.