Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

FinalHandler always uses OK as reasonPhrase if non previously set #51

Closed
nesl247 opened this issue Mar 21, 2016 · 1 comment
Closed

Comments

@nesl247
Copy link

nesl247 commented Mar 21, 2016

If an error makes it to handleError, without a reasonPhrase, it will always be OK. This is because when calling withStatus, it is passing getReasonPhrase which checks if there is one set, and if not uses it from the current statusCode. Of course statusCode is 200 at that time because it's the default in the constructor.

@michaelmoussa
Copy link
Contributor

I believe #52 will resolve this, @nesl247 /cc @weierophinney

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants