This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue reported in #51.
#46 ensured that response reason phrases set by developers would be preserved when building error responses. Unfortunately, it also ensured that reason phrases NOT set by developers (i.e., "OK") would also be preserved.
This PR takes the following use cases into account. Let me know if I missed a possibility!
FinalHandler
(maybe another middleware in the error middleware pipeline does some kind of logging or external error reporting, and that failed). In this case, the reason phrase will be preserved if the resulting exception doesn't change the status code. If it does, then there will be a new reason phrase. I expect this should be a rare occurrence, but at least there is a sane default behavior when it happens.