This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Final handler return prev exceptions in development mode #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
added a commit
that referenced
this pull request
Mar 17, 2016
Final handler return prev exceptions in development mode
weierophinney
added a commit
that referenced
this pull request
Mar 17, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 17, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 17, 2016
Patch #39 added the method `testInvokingWithExceptionInNonProductionModeIncludesPrevTraceInResponseBody`. The test fails after adding the code from #46, as that code modifies `FinalHandler` to never provide exception details unless in non-production mode (which is the default). This patch updates the test to set the final handler used in the test setup to set the environment to development so that the expectations pass.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.