This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Do not mark response as complete in FinalHandler #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in zendframework#53, because utilities such as the `SapiEmitter` need to update the response prior to sending it, marking the response as complete has an adverse impact since the release of 1.2.0, as this will now cause an exception. This patch fixes that situation by using the `write()` method in favor of `end()` within the `FinalHandler::completeResponse()` method.
*sigh*
weierophinney
added a commit
that referenced
this pull request
Mar 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #53, because utilities such as the
SapiEmitterneed to update the response prior to sending it, marking the response as complete has an adverse impact since the release of 1.2.0, as this will now cause an exception.This patch fixes that situation by using the
write()method in favor ofend()within theFinalHandler::completeResponse()method.