Remove HTTP namespace #71
Conversation
|
Marking as a WIP until #70 is merged to develop. |
This patch removes all code in the `Zend\Stratigility\Http` namespace, and updates the `MiddlewarePipe` implementation to no longer decorate the request and response instances with artifacts from that namespace. In auditing tests, discovered a few locations where `$response->write()` was being called within the tests themselves; those have been corrected to `$response->getBody()->write()`. Additionally, code for suppressing deprecation notices from the removed classes within test cases was removed.
weierophinney
force-pushed
the
feature/deprecator-removal
branch
from
3f46d4c
to
bce8983
Compare
|
With #70 merged, ready for review; pinging @zendframework/community-review-team , @michaelmoussa , and @xtreamwayz. |
There was a problem hiding this comment.
Looks good to me.
I was wondering, the WhoopsErrorHandler checks for the Zend\Stratigility\Http\Request and grabs the original request from it. But I guess if you push it first in the pipeline it already has access to the original request, before any other middleware can mess with it.
Correct, and once we have a 1.3 version of Stratigility released, I'll update that handler to use the |
|
👍 LGTM too. |
|
I really like all the changes. It makes understanding and customizing error handling a lot easier. |
|
With this in place, I've updated the branch-aliases across all branches to:
As such, you should be able to test against the upcoming 1.3 or 2.0 versions using appropriate constraints (e.g., |
This patch is against dev-2.0.0 and builds on #70, removing the classes and interfaces from the
Zend\Stratigility\Httpnamespace deprecated by that patch.Internally, this only affects
MiddlewarePipeon this branch, as that class was decorating the incoming request and response at invocation; however, no other code was utilizing their features.This patch targets the 2.0.0 release.