Add generate test duration file cron #2347

safoinme · 2024-01-23T17:54:37Z

Describe changes

I implemented/fixed _ to achieve _.

Pre-requisites

Please ensure you have done the following:

I have read the CONTRIBUTING.md document.
If my change requires a change to docs, I have updated the documentation accordingly.
I have added tests to cover my changes.
I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Other (add details above)

Summary by CodeRabbit

Chores
- Improved continuous integration workflow to include test duration tracking across different environments.

coderabbitai · 2024-01-23T17:54:43Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The updates introduce a new CI job that runs tests across different environments and generates a test duration report. It leverages a separate workflow to create the report, which includes setting up the environment, handling credentials, and installing dependencies. Upon detecting changes, it can also initiate a pull request.

Changes

File Path	Change Summary
`.github/workflows/.../ci-fast.yml`	Added `test-generate-test-duration` job using a matrix strategy, with custom action and secret inheritance.
`.github/workflows/.../generate-test-duration.yml`	New workflow to create test duration file; includes environment setup, credential configuration, dependency installation, test execution, and pull request generation on changes.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

strickvl · 2024-01-24T07:49:36Z

@coderabbitai review

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between a9925e7 and 9fb7cf0.

Files selected for processing (2)

.github/workflows/ci-fast.yml (1 hunks)
.github/workflows/generate-test-duration.yml (1 hunks)

Additional comments: 2

.github/workflows/ci-fast.yml (1)

89-101: The new job test-generate-test-duration has been added correctly with a matrix strategy for different operating systems, Python versions, and test environments. The job uses a custom action and inherits secrets as expected.

.github/workflows/generate-test-duration.yml (1)

1-220: The workflow generate-test-duration.yml is well-structured with clear inputs and a comprehensive set of jobs that cover various configurations and environments. It includes steps for setting up credentials, environment variables, and handling potential changes in the test duration file. The workflow also accounts for different operating systems and test environments, which is good for ensuring compatibility across various setups.

strickvl

Looks ok, but this isn't a cron job. It just runs every time we run the fast CI which feels maybe too often?

.github/workflows/ci-fast.yml

.github/workflows/generate-test-duration.yml

strickvl · 2024-01-24T09:52:47Z

/fulltest

…generate

CLAassistant · 2024-01-24T13:37:17Z

All committers have signed the CLA.

…ithub.com:zenml-io/zenml into feature/OSSK-365-cron-test-duration-file-generate

…generate

.github/workflows/generate-test-duration.yml

Co-authored-by: Alex Strick van Linschoten <[email protected]>

…generate

* add generate test duration file cron * Refactor workflow to generate test duration file * Add test-generate-test-duration job to ci-fast workflow * Fix coverage script to handle test failures gracefully * Update secrets inheritance in ci-fast.yml * Add continue-on-error flag to Generate test duration step * Update .test_duration workflow * Update .test_duration file due to detected changes * Update test duration file with new changes * Update test duration file generation workflow * Remove unused job from ci-fast workflow * Add workflow_call trigger to generate-test-duration.yml * Remove tmate setup action from workflow * Update test duration file name * new changes on test duration file detected at 20240124-133657 * Update branch reference in generate-test-duration.yml * Remove unused test-generate-test-duration job * Update .github/workflows/generate-test-duration.yml Co-authored-by: Alex Strick van Linschoten <[email protected]> --------- Co-authored-by: ZenML GmbH <[email protected]> Co-authored-by: Alex Strick van Linschoten <[email protected]>

add generate test duration file cron

143c7c6

safoinme requested a review from strickvl January 23, 2024 17:54

github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Jan 23, 2024

safoinme added 7 commits January 23, 2024 18:59

Refactor workflow to generate test duration file

cf20cc6

Add test-generate-test-duration job to ci-fast workflow

930bbce

Fix coverage script to handle test failures gracefully

b54a2ed

Update secrets inheritance in ci-fast.yml

28be0c4

Add continue-on-error flag to Generate test duration step

2540857

Update .test_duration workflow

faad731

Update .test_duration file due to detected changes

9fb7cf0

coderabbitai bot reviewed Jan 24, 2024

View reviewed changes

strickvl requested changes Jan 24, 2024

View reviewed changes

.github/workflows/ci-fast.yml Outdated Show resolved Hide resolved

.github/workflows/generate-test-duration.yml Outdated Show resolved Hide resolved

safoinme added 4 commits January 24, 2024 09:31

Update test duration file with new changes

b31b57d

Update test duration file generation workflow

57c7fb9

Remove unused job from ci-fast workflow

bce399d

Add workflow_call trigger to generate-test-duration.yml

8995002

strickvl reviewed Jan 24, 2024

View reviewed changes

.github/workflows/generate-test-duration.yml Outdated Show resolved Hide resolved

safoinme and others added 4 commits January 24, 2024 11:34

Remove tmate setup action from workflow

9c07b38

Update test duration file name

367b27f

Merge branch 'develop' into feature/OSSK-365-cron-test-duration-file-…

1944dce

…generate

new changes on test duration file detected at 20240124-133657

2e96b97

safoinme added 2 commits January 24, 2024 15:52

Update branch reference in generate-test-duration.yml

7e78f1b

Merge branch 'feature/OSSK-365-cron-test-duration-file-generate' of g…

0c64f60

…ithub.com:zenml-io/zenml into feature/OSSK-365-cron-test-duration-file-generate

safoinme requested a review from strickvl January 24, 2024 14:53

Remove unused test-generate-test-duration job

26d7778

safoinme requested a review from avishniakov January 24, 2024 14:53

Merge branch 'develop' into feature/OSSK-365-cron-test-duration-file-…

384d1d6

…generate

avishniakov reviewed Jan 24, 2024

View reviewed changes

.github/workflows/generate-test-duration.yml Show resolved Hide resolved

avishniakov approved these changes Jan 24, 2024

View reviewed changes

strickvl requested changes Jan 24, 2024

View reviewed changes

.github/workflows/generate-test-duration.yml Outdated Show resolved Hide resolved

safoinme and others added 2 commits January 24, 2024 17:39

Update .github/workflows/generate-test-duration.yml

653b650

Co-authored-by: Alex Strick van Linschoten <[email protected]>

Merge branch 'develop' into feature/OSSK-365-cron-test-duration-file-…

ba18a84

…generate

safoinme requested a review from strickvl January 24, 2024 16:39

strickvl approved these changes Jan 24, 2024

View reviewed changes

safoinme merged commit 84e616c into develop Jan 24, 2024
22 of 24 checks passed

safoinme deleted the feature/OSSK-365-cron-test-duration-file-generate branch January 24, 2024 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add generate test duration file cron #2347

Add generate test duration file cron #2347

safoinme commented Jan 23, 2024 •

edited

Loading

coderabbitai bot commented Jan 23, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

strickvl commented Jan 24, 2024

coderabbitai bot left a comment

strickvl left a comment

strickvl commented Jan 24, 2024

CLAassistant commented Jan 24, 2024 •

edited

Loading

Add generate test duration file cron #2347

Add generate test duration file cron #2347

Conversation

safoinme commented Jan 23, 2024 • edited Loading

Describe changes

Pre-requisites

Types of changes

Summary by CodeRabbit

coderabbitai bot commented Jan 23, 2024 • edited Loading

Auto Review Skipped

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

strickvl commented Jan 24, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

strickvl left a comment

Choose a reason for hiding this comment

strickvl commented Jan 24, 2024

CLAassistant commented Jan 24, 2024 • edited Loading

safoinme commented Jan 23, 2024 •

edited

Loading

coderabbitai bot commented Jan 23, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

CLAassistant commented Jan 24, 2024 •

edited

Loading