-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CI run on the appropriate branch #2358
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughThe modifications across the GitHub workflow files revolve around enhancing the checkout process. The changes introduce scripts to dynamically obtain pull request details and use this information to checkout code. This allows the workflows to adapt to different PR contexts, potentially improving CI efficiency and accuracy when running tests against the latest code changes. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (3)
- .github/workflows/ci-slow.yml (3 hunks)
- .github/workflows/integration-test-slow.yml (1 hunks)
- .github/workflows/unit-test.yml (1 hunks)
Additional comments: 10
.github/workflows/unit-test.yml (2)
- 76-93: The script added to fetch PR details for non-pull_request events is a good addition. However, ensure that the error handling is robust and that the failure of this step will not cause issues in subsequent steps if the PR details are not required for them.
- 94-98: The checkout step now dynamically determines the repository and ref to checkout based on the event type. This is a crucial change for ensuring that the CI runs against the correct branch. Verify that this change is tested across different event types to ensure it behaves as expected.
.github/workflows/integration-test-slow.yml (2)
- 132-147: The addition of the GitHub script to fetch PR details is consistent with the changes in the unit-test.yml file. Ensure that the error handling is robust and that the failure of this step will not cause issues in subsequent steps if the PR details are not required for them.
- 149-151: The checkout step has been updated to use the PR details fetched by the previous step. This is a crucial change for ensuring that the CI runs against the correct branch. Verify that this change is tested across different event types to ensure it behaves as expected.
.github/workflows/ci-slow.yml (6)
- 62-77: The addition of the GitHub script to fetch PR details is consistent with the changes in the other workflow files. Ensure that the error handling is robust and that the failure of this step will not cause issues in subsequent steps if the PR details are not required for them.
- 78-81: The checkout step has been updated to use the PR details fetched by the previous step. This is a crucial change for ensuring that the CI runs against the correct branch. Verify that this change is tested across different event types to ensure it behaves as expected.
- 103-118: The addition of the GitHub script to fetch PR details in the sqlite-db-migration-testing job is consistent with the changes in the other workflow files. Ensure that the error handling is robust and that the failure of this step will not cause issues in subsequent steps if the PR details are not required for them.
- 119-122: The checkout step in the sqlite-db-migration-testing job has been updated to use the PR details fetched by the previous step. This is a crucial change for ensuring that the CI runs against the correct branch. Verify that this change is tested across different event types to ensure it behaves as expected.
- 142-157: The addition of the GitHub script to fetch PR details in the small-checks job is consistent with the changes in the other workflow files. Ensure that the error handling is robust and that the failure of this step will not cause issues in subsequent steps if the PR details are not required for them.
- 158-161: The checkout step in the small-checks job has been updated to use the PR details fetched by the previous step. This is a crucial change for ensuring that the CI runs against the correct branch. Verify that this change is tested across different event types to ensure it behaves as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go
* use the PR branch * remove comment-driven part * checkout the correct repo * add conditional check for comment-driven trigger * add conditional checks for slow CI * Remove unused workflow triggers in ci-slow.yml
* use the PR branch * remove comment-driven part * checkout the correct repo * add conditional check for comment-driven trigger * add conditional checks for slow CI * Remove unused workflow triggers in ci-slow.yml
* use the PR branch * remove comment-driven part * checkout the correct repo * add conditional check for comment-driven trigger * add conditional checks for slow CI * Remove unused workflow triggers in ci-slow.yml
Slow CI was (is currently) only running on
main
, even if you triggered it with a comment inside a PR. This PR fixes that.Summary by CodeRabbit