Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label studio settings and optional port #2628

Merged
merged 11 commits into from
Apr 30, 2024
Merged

Conversation

htahir1
Copy link
Contributor

@htahir1 htahir1 commented Apr 22, 2024

I added an api key settings to the label studio annotator so that we can share the stack component.
Also port is now optional when using the annotator.

Summary by CodeRabbit

  • New Features
    • Introduced new settings for Label Studio integration to enhance API key management.

@htahir1 htahir1 requested a review from strickvl April 22, 2024 21:46
Copy link
Contributor

coderabbitai bot commented Apr 22, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent updates in the ZenML Label Studio integration focus on enhancing the configuration management for annotators. A new LabelStudioAnnotatorSettings class has been introduced, centralizing API key settings, and modifications to existing classes and methods ensure seamless integration of these settings.

Changes

File Path Change Summary
.../label_studio/annotators/label_studio_annotator.py - Added import and new property for LabelStudioAnnotatorSettings.
- Updated _get_client for API key handling.
.../label_studio/flavors/__init__.py - Exported LabelStudioAnnotatorSettings.
.../label_studio/flavors/label_studio_annotator_flavor.py - Introduced LabelStudioAnnotatorSettings with api_key attribute.
- Refactored LabelStudioAnnotatorConfig to include new settings class.

🐰✨
In the land of code and wire,
A rabbit hopped, with an aim so higher.
Twas' not just any mundane tweak,
But a dance of settings, unique and chic.
Hop hop hurray, for changes so grand,
In the realm of ZenML, they proudly stand!
🌟🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Apr 22, 2024
@strickvl
Copy link
Contributor

@coderabbitai review

@strickvl
Copy link
Contributor

Should probably merge #2626 here too

@htahir1
Copy link
Contributor Author

htahir1 commented Apr 23, 2024

@strickvl I merged your branch, you can close yours and just review this

@strickvl strickvl changed the title Label studio settings Label studio settings and optional port Apr 23, 2024
@htahir1 htahir1 requested a review from bcdurak April 29, 2024 07:35
Copy link
Contributor

@bcdurak bcdurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment. Otherwise LGTM.

@strickvl strickvl requested a review from bcdurak April 30, 2024 15:17
@strickvl strickvl merged commit cb07d3a into develop Apr 30, 2024
57 of 58 checks passed
@strickvl strickvl deleted the feature/label-studio-unlock branch April 30, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal To filter out internal PRs and issues run-slow-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants