Microchip addition of new devices PIC32CX_SG41, PIC32CX_SG60, PIC32CX_SG61 #21

MyGh64605 · 2024-07-09T17:20:32Z

These devices are compatible with ATSAMD/E XX series of devices that are currently incorporated within Zephyr.

These modifications are for the HAL layer only.
Boards will be added later.

commit 71eba05 Author: Scott Worley <[email protected]> Date: Tue May 21 17:32:20 2024 -0400 hal: microchip: mec5: Version 0.2 MEC5 HAL consistent naming Change symbols name to use prefix "mec_hal_" to prevent name clashes with symbols from other components (application, Zephyr, etc). Signed-off-by: Scott Worley <[email protected]> commit 1279561 Author: Scott Worley <[email protected]> Date: Mon May 13 10:05:22 2024 -0400 hal: microchip: mec5: Add initial I2C Network HAL support Add initial HAL API for starting an I2C transfer using the network layer in the I2C controller. Add an API to enable and disable network layer interrupts. Signed-off-by: Scott Worley <[email protected]> commit f95f0f5 Author: Scott Worley <[email protected]> Date: Mon May 13 10:00:58 2024 -0400 hal: microchip: mec5: Fix bug in central DMA configuration Fix a bug in central DMA channel configuration. The bug was not found by Zephyr DMA driver tests because these tests only exercise memory to memory transfers. The bug was in code paths for peripheral DMA to/from memory. Bug was found during I2C network layer driver development since this driver uses central DMA. Signed-off-by: Scott Worley <[email protected]> commit 6985aff Author: Scott Worley <[email protected]> Date: Mon May 6 15:41:12 2024 -0400 hal: microchip: mec5: Add HAL for MEC174x, MEC175x, and MECH172x. Add a full HAL (header and peripheral C code) for Microchip "MEC5" family SoC's: MEC174x and MEC175x. Also support the older MEC172x whose HAL name is MECH172x. The HAL also include device tree PINCTRL files. NOTE: This is version 0.1 of the HAL and is not feature complete. Signed-off-by: Scott Worley <[email protected]>

hal: microchip: pic32cx:Adding support for Microchip PIC32CX SG devices This is based on the hal atmel libraries as a starting point. Signed-off-by: Michael Sherwood <[email protected]>

MyGh64605 · 2024-07-09T17:51:12Z

Question, should I create a pull request for the main Zephyr project or wait until this request is approved.

MyGh64605 · 2024-07-09T17:54:45Z

@nandojve This is first pull request to incorporate the PIC32CX SG devices, that are compatible with the ATDAMD/E XX devices.

commit 1281fa5866a0f9dcb78c5902ba1633bd163318da Author: Zephyr DeveloperMichael <[email protected]> Date: Mon Jul 8 08:04:22 2024 -0700 Squashed commit of the following: commit 8bcb80b Author: Zephyr DeveloperMichael <[email protected]> Date: Thu Jun 27 10:02:26 2024 -0700 Squashed commit of the following: commit 71eba05 Author: Scott Worley <[email protected]> Date: Tue May 21 17:32:20 2024 -0400 hal: microchip: mec5: Version 0.2 MEC5 HAL consistent naming Change symbols name to use prefix "mec_hal_" to prevent name clashes with symbols from other components (application, Zephyr, etc). Signed-off-by: Scott Worley <[email protected]> commit 1279561 Author: Scott Worley <[email protected]> Date: Mon May 13 10:05:22 2024 -0400 hal: microchip: mec5: Add initial I2C Network HAL support Add initial HAL API for starting an I2C transfer using the network layer in the I2C controller. Add an API to enable and disable network layer interrupts. Signed-off-by: Scott Worley <[email protected]> commit f95f0f5 Author: Scott Worley <[email protected]> Date: Mon May 13 10:00:58 2024 -0400 hal: microchip: mec5: Fix bug in central DMA configuration Fix a bug in central DMA channel configuration. The bug was not found by Zephyr DMA driver tests because these tests only exercise memory to memory transfers. The bug was in code paths for peripheral DMA to/from memory. Bug was found during I2C network layer driver development since this driver uses central DMA. Signed-off-by: Scott Worley <[email protected]> commit 6985aff Author: Scott Worley <[email protected]> Date: Mon May 6 15:41:12 2024 -0400 hal: microchip: mec5: Add HAL for MEC174x, MEC175x, and MECH172x. Add a full HAL (header and peripheral C code) for Microchip "MEC5" family SoC's: MEC174x and MEC175x. Also support the older MEC172x whose HAL name is MECH172x. The HAL also include device tree PINCTRL files. NOTE: This is version 0.1 of the HAL and is not feature complete. Signed-off-by: Scott Worley <[email protected]> commit 81f02ec Author: Zephyr DeveloperMichael <[email protected]> Date: Tue Jun 25 07:37:16 2024 -0700 Adding support for Microchip PIC32CX SG devices commit e25427c Author: Zephyr DeveloperMichael <[email protected]> Date: Mon Jun 24 09:27:09 2024 -0700 Adding support for Microchip PIC32CX SG devices commit 22f2a0d Author: Zephyr DeveloperMichael <[email protected]> Date: Tue Jun 18 12:20:35 2024 -0700 Adding support for Microchip PIC32CX SG devices commit 1bf0f21 Author: Zephyr DeveloperMichael <[email protected]> Date: Tue Jun 18 11:51:34 2024 -0700 Adding support for Microchip PIC32CX SG devices commit c26836d Author: Zephyr DeveloperMichael <[email protected]> Date: Fri Jun 14 11:06:25 2024 -0700 Adding support for Microchip PIC32CX SG devices commit 3002c9f Author: Zephyr DeveloperMichael <[email protected]> Date: Mon Jun 3 12:38:17 2024 -0700 Adding support for Microchip PIC32CX SG devices commit e2b7978 Author: Zephyr DeveloperMichael <[email protected]> Date: Fri May 31 11:08:36 2024 -0700 Adding support for Microchip PIC32CX SG devices commit f026a5b Author: Zephyr DeveloperMichael <[email protected]> Date: Fri May 31 09:52:56 2024 -0700 Adding support for Microchip PIC32CX SG devices commit d12239d Author: Zephyr DeveloperMichael <[email protected]> Date: Fri May 31 09:47:00 2024 -0700 Adding support for Microchip PIC32CX SG devices commit 7c3252a Author: Zephyr DeveloperMichael <[email protected]> Date: Thu May 30 06:11:19 2024 -0700 Adding support for Microchip PIC32CX SG devices commit 29156b3 Author: Zephyr DeveloperMichael <[email protected]> Date: Mon May 13 12:32:30 2024 -0700 Adding support for Microchip PIC32CX SG devices commit 678ee3b Author: Zephyr DeveloperMichael <[email protected]> Date: Mon May 13 08:59:00 2024 -0700 Adding support for Microchip PIC32CX SG devices commit 7902150 Author: Zephyr DeveloperMichael <[email protected]> Date: Tue May 7 08:02:14 2024 -0700 Adding support for Microchip PIC32CX SG devices commit 82d8d1b Author: Zephyr DeveloperMichael <[email protected]> Date: Mon May 6 11:32:54 2024 -0700 Adding support for Microchip PIC32CX SG devices commit 0229627 Author: Zephyr DeveloperMichael <[email protected]> Date: Mon May 6 10:02:09 2024 -0700 Adding support for Microchip PIC32CX SG devices commit 68575aa Author: Fabio Baltieri <[email protected]> Date: Tue Feb 27 14:05:51 2024 +0000 CMakeLists: use MEC15XX for the series option Rename the SoC series option to MEC15XX to align with the new hwmv2 config name, drop the 1701x option which had no references anyway. Signed-off-by: Fabio Baltieri <[email protected]> commit 9fc0e92 Author: Fabio Baltieri <[email protected]> Date: Tue Feb 27 14:05:51 2024 +0000 CMakeLists: use MEC15XX for the series option Rename the SoC series option to MEC15XX to align with the new hwmv2 config name, drop the 1701x option which had no references anyway. Signed-off-by: Fabio Baltieri <[email protected]> Merge branch 'master' of https://github.com/MyGh64605/hal_microchip

kartben · 2024-07-09T19:07:22Z

Question, should I create a pull request for the main Zephyr project or wait until this request is approved.

https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules

scottwcpg

Please move into subfolder. DTS can be at the top level because it has subfolders for vendor/chip_family.

scottwcpg · 2024-07-09T19:05:06Z

CMakeLists.txt

add_subdirectory(mplabx) add this path to MEC_HAL (CPG old stuff), MPFS_HAL (microsemi RISC-V), and MEC5_HAL (CPU new stuff). Should be add_subdirectory_ifdef

I think this is a good opportunity to start organize the content. I believe that having names like ASF or MPLABX do not help. The content that are placed inside those folders are platform specific, The platform directory should have a tree that follows an specific family. Inside each family the variants will be placed. The below tree presents 2 well know families sam and sam0. The new pic32cxsg should be organized in the same manner. I let to you propose the names but I believe the content will be well organized as in the below tree.

Notes:

1- Add the .github rules that are available on hal_atmel to check if the licenses are compliance with Zephyr rules.
2- The mec/mec5/mpfs are candidates to be moved inside platform [Improvement - not part of this PR]

. ├── .github │ ├── license_config.yml │ └── workflows │ ├── license_check.yml │ └── test.yml ├── platform │ ├── CMakeLists.txt │ ├── common │ │ ├── CMakeLists.txt │ │ └── components │ ├── ? family name │ │ ├── CMakeLists.txt │ │ └── include │ │ ├── ? part variant name │ │ └── next gen ? │ ├── sam │ │ ├── CMakeLists.txt │ │ └── include │ │ ├── sam3x │ │ ├── sam4e │ │ ├── sam4l │ │ ├── sam4s │ │ ├── same70 │ │ ├── same70b │ │ ├── samv71 │ │ └── samv71b │ └── sam0 │ ├── CMakeLists.txt │ └── include │ ├── CMakeLists.txt │ ├── samc20 │ ├── samc20n │ ├── samc21 │ ├── samc21n │ ├── samd20 │ ├── samd21 │ ├── samd51 │ ├── same51 │ ├── same53 │ ├── same54 │ ├── saml21 │ ├── samr21 │ ├── samr34 │ └── samr35 ├── CMakeLists.txt ├── include │ └── dt-bindings │ └── pinctrl ├── pinconfigs │ ├── README.md │ ├── sam-3x.yml │ ├── sam-4e.yml │ ├── sam-4l.yml │ ├── sam-4s-4sa-4sd.yml │ ├── sam-c2x.yml │ ├── sam-d2x-da1-abcd.yml │ ├── sam-d5x-e5x.yml │ ├── sam-l21.yml │ ├── sam-r21.yml │ ├── sam-r34-r35.yml │ └── sam-s70-e70-v7x.yml ├── README.md ├── scripts │ ├── README.md │ ├── requirements-dev.txt │ ├── requirements-test.txt │ ├── requirements.txt │ ├── sampinctrl.py │ └── tests │ └── sampinctrl └── zephyr

I think @nandojve suggestion for organization is a good one. have you thought about it @scottwcpg?

I think this can make more sense when you think about integration of hal_mchp/atmel in the future. So, everything goes in the right place and future generations will be side by side. This makes zephyr soc configuration far more easy to handle since hal will be same for MCUs independent of the core ARM/RISC-V etc.

scottwcpg · 2024-07-09T19:06:50Z

README.md

All the original content is gone. Many of your instructions do not apply to the the other HAL's. These HAL's use the zephyr SDK toolchain.

I still think to have a platform folder name instead pic32c seems better for the long run. Then, when moving sam, sam0 they will be side by side with pic32cxsg instead creating 2 new folders on the root folder.

scottwcpg · 2024-07-09T19:07:39Z

README.md

+The above are general guidelines and exceptions could happen. In this case, the
+exception should be addressed at review phase.
+
+## The standard API


This applies to our HAL only. The others use their own naming convention.

scottwcpg · 2024-07-09T19:11:00Z

include/dt-bindings/pinctrl/microchip_pic32cxsg_pinctrl.h

@@ -0,0 +1,179 @@
+/*


This folder is at the top level. Most hal_vendor folders have subdirectories containing the whole chip family. mec, mec5, mpfs contain all the specific stuff for those chip families. Is it possible for you to put your stuff in a subdirectory also, so we are all consistent and isolated?

nandojve · 2024-07-10T16:39:22Z

Hi @MyGh64605,

@nandojve This is first pull request to incorporate the PIC32CX SG devices, that are compatible with the ATDAMD/E XX devices.

Ok, I'll start to review soon.

nandojve

Hi @MyGh64605 ,

Question, should I create a pull request for the main Zephyr project or wait until this request is approved.

It is very important to follow the how-to-submit-code. I also recommend this old side that help to understand how I usually expect a commit message https://cbea.ms/git-commit. Not a must - desirable.

It is important organize the commit brief message to allow easy filtering. Usually I start this way:

1- More than one device, try group by family
2- functionality: family or device. Try get some inspiration from hal_atmel:

* c1c4410 - docs: Improve documentation (1 year, 4 months ago) <Gerson Fernando Budke>
* d45adfb - samc20: samc21: Add ADC_INPUTCTRL internal ground for ADC Driver (1 year, 9 months ago) <Kamil Serwus>
* ffe9191 - pinctrl: sam-c2x: Add pinconfigs and include files (1 year, 9 months ago) <Kamil Serwus>
* 3eaaa0b - ext: Import Atmel SAMC20 header files from ASF library (1 year, 9 months ago) <Kamil Serwus>
* a269f63 - ext: Import Atmel SAMC21 header files from ASF library (1 year, 9 months ago) <Kamil Serwus>
* 840b6ac - sam0: Add revisions to soc includes (1 year, 9 months ago) <Kamil Serwus>
* 43c73d8 - sam4l: Add US_MR_CHRL_{n}_BIT Register Aliases for USART Driver (1 year, 9 months ago) <Nick Kraus>
* 1d237f2 - samv71b: Fix CIDR for V71 Revision B Silicon (1 year, 11 months ago) <Nick Kraus>
* bb4e710 - CMakeLists.txt: Add include directory only for atmel devices (2 years ago) <Yonatan Schachter>
* a486271 - winc1500: nmspi: Fix compiler warning (2 years, 1 month ago) <Kumar Gala>
* 7458978 - ext: winc1500: Rename function to avoid name clash (2 years, 1 month ago) <Ole Morten Haaland>
* 7518d0b - pinctrl: sam-r34-r35: Add pinconfigs and include files (2 years, 3 months ago) <Attie Grande>
* 8989ec4 - pinctrl: sam-l21: Add pinconfigs and include files (2 years, 3 months ago) <Attie Grande>
* 7e9d3fc - ext: Import Atmel SAMR35 header files from ASF library (2 years, 3 months ago) <Attie Grande>
* 4749709 - ext: Import Atmel SAMR34 header files from ASF library (2 years, 3 months ago) <Attie Grande>
* ceacbcb - ext: Import Atmel SAML21 header files from ASF library (2 years, 3 months ago) <Attie Grande>
* 2c2ce9f - ci: license_check: Update to scancode action v4 (2 years, 4 months ago) <Stephanos Ioannidis>
* 78c5567 - samv71: patch: Fix XDMAC_CHID register name (2 years, 4 months ago) <Gerson Fernando Budke>
* 94d8d86 - pinctrl: pinconfigs: Add README file (2 years, 4 months ago) <Gerson Fernando Budke>
* 5efcf60 - pinctrl: sam-d51-d53-d54: Add pinconfigs and include files (2 years, 4 months ago) <Gerson Fernando Budke>
* 5a4f715 - pinctrl: sam-r21: Add pinconfigs and include files (2 years, 4 months ago) <Gerson Fernando Budke>
* 3d10116 - pinctrl: sam-d20-d21-da1: Add pinconfigs and include files (2 years, 4 months ago) <Gerson Fernando Budke>
* 1876356 - pinctrl: sam-s70-e70-v7x: Add pinconfigs and include files (2 years, 4 months ago) <Gerson Fernando Budke>
* b33b97a - pinctrl: sam-4s-4sa-4sd: Add pinconfigs and include files (2 years, 4 months ago) <Gerson Fernando Budke>
* 845b8f2 - pinctrl: sam-4l: Add pinconfigs and include files (2 years, 4 months ago) <Gerson Fernando Budke>
* 674b12d - pinctrl: sam-4e: Add pinconfigs and include files (2 years, 4 months ago) <Gerson Fernando Budke>
* ac2bac9 - pinctrl: sam-3x: Add pinconfigs and include files (2 years, 4 months ago) <Gerson Fernando Budke>
* 527de70 - pinctrl: Add pinctrl tests (2 years, 4 months ago) <Gerson Fernando Budke>
* 9597144 - pinctrl: Add pinctrl script (2 years, 4 months ago) <Gerson Fernando Budke>
* 45cb8f8 - patch: samd21/r21: Normalize underscore defines (2 years, 4 months ago) <Gerson Fernando Budke>
* 7c24242 - patch: samd21: Correct missing underscore in defines for variants (2 years, 5 months ago) <rocky134>

It is mandatory when add a new platform to have a new board at same time. The board only needs a serial port on pooling mode that runs the hello world application. This means that we need to align hal / soc / devicetree / board. On the remaining features will be add incrementally. This allows us to do a good review process and make sure that both tests are Ok and code is on a usable stage.

nandojve · 2024-07-15T18:29:49Z

CMakeLists.txt

I think this is a good opportunity to start organize the content. I believe that having names like ASF or MPLABX do not help. The content that are placed inside those folders are platform specific, The platform directory should have a tree that follows an specific family. Inside each family the variants will be placed. The below tree presents 2 well know families sam and sam0. The new pic32cxsg should be organized in the same manner. I let to you propose the names but I believe the content will be well organized as in the below tree.

Notes:

1- Add the .github rules that are available on hal_atmel to check if the licenses are compliance with Zephyr rules.
2- The mec/mec5/mpfs are candidates to be moved inside platform [Improvement - not part of this PR]

. ├── .github │ ├── license_config.yml │ └── workflows │ ├── license_check.yml │ └── test.yml ├── platform │ ├── CMakeLists.txt │ ├── common │ │ ├── CMakeLists.txt │ │ └── components │ ├── ? family name │ │ ├── CMakeLists.txt │ │ └── include │ │ ├── ? part variant name │ │ └── next gen ? │ ├── sam │ │ ├── CMakeLists.txt │ │ └── include │ │ ├── sam3x │ │ ├── sam4e │ │ ├── sam4l │ │ ├── sam4s │ │ ├── same70 │ │ ├── same70b │ │ ├── samv71 │ │ └── samv71b │ └── sam0 │ ├── CMakeLists.txt │ └── include │ ├── CMakeLists.txt │ ├── samc20 │ ├── samc20n │ ├── samc21 │ ├── samc21n │ ├── samd20 │ ├── samd21 │ ├── samd51 │ ├── same51 │ ├── same53 │ ├── same54 │ ├── saml21 │ ├── samr21 │ ├── samr34 │ └── samr35 ├── CMakeLists.txt ├── include │ └── dt-bindings │ └── pinctrl ├── pinconfigs │ ├── README.md │ ├── sam-3x.yml │ ├── sam-4e.yml │ ├── sam-4l.yml │ ├── sam-4s-4sa-4sd.yml │ ├── sam-c2x.yml │ ├── sam-d2x-da1-abcd.yml │ ├── sam-d5x-e5x.yml │ ├── sam-l21.yml │ ├── sam-r21.yml │ ├── sam-r34-r35.yml │ └── sam-s70-e70-v7x.yml ├── README.md ├── scripts │ ├── README.md │ ├── requirements-dev.txt │ ├── requirements-test.txt │ ├── requirements.txt │ ├── sampinctrl.py │ └── tests │ └── sampinctrl └── zephyr

nandojve · 2024-07-15T18:38:52Z

include/dt-bindings/pinctrl/microchip_pic32cxsg_pinctrl.h

+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+#ifndef DT_BINDINGS_PINCTRL_MICROCHIP_PIC32CXSG_PINCTRL_H_


I'm glad to see that MCHP appreciate the work that was made on the hal_atmel. This means that all the files that have copyright that are base for some work in this repository and were captured from hal_atmel or even are inspirations for some derived work in this repository must have the original copyright.

nandojve · 2024-07-15T18:50:42Z

mplabx/pic32cxsg/CMakeLists.txt

+# SPDX-License-Identifier: Apache-2.0
+#
+
+add_subdirectory(include)


File should have a newline at end.
Fix all the files that apply.

Good afternoon,
I will make the suggested modifications.

Will multiple pull requests need to be made ?
This one for hal_microchip and
One to add the board files ?
One to modify 'west.yml' ?
One to add the soc files etc ...... ?

FYI,
I have created or modified all the pertinent files within the main Zephyr directory. Created a 'Hello World' project for both of the evaluation boards to be added.
The 'Hello World' project compiles without error.

nandojve · 2024-07-15T18:52:29Z

mplabx/pic32cxsg/include/pic32cxsg41/component-version.h

@@ -0,0 +1,56 @@
+/*


run find * type f -print0 | xargs -0 dos2unix -k on all the files imported and make sure they are using utf-8 format.

Good afternoon, will this command actually 'fixup' the files and provide a list of modified files ?

Good afternoon,

error after running this command

"'xargs' is not recognized as an internal or external command,
operable program or batch file."

…CXSG61 boards build After running command "find * -type f -print0 | xargs -0 dos2unix -k"

…CXSG61 boards build After running command "find * -type f -print0 | xargs -0 dos2unix -k" Signed-off-by: Michael D Sherwood <[email protected]>

Addressing PR comments: Renamed 'mplax' folder to 'pic32c', tested that PIC32CXSG41 and PIC32CXSG61 boards build After running command "find * -type f -print0 | xargs -0 dos2unix -k" Signed-off-by: Michael Sherwood <[email protected]>

Signed-off-by: Michael D Sherwood <[email protected]>

MyGh64605 · 2024-07-30T18:51:37Z

Have updated the hal_microchip PIC32CX SG files.

Associated pull request for the addition of the PIC32CX_SG devices to zephyr main:
zephyrproject-rtos/zephyr#76503

nandojve

Overall LGTM. I'll suggest to change the title to pic32c: Introduce hal platform

nandojve · 2024-08-01T12:06:12Z

scripts/pic32cxsgpinctrl.py

@@ -0,0 +1,287 @@
+# Copyright (c) 2024 Microchip


You should keep original copyright with the new one, even when you rename a file.

nandojve · 2024-08-01T12:06:51Z

scripts/pic32pinctrl.py

@@ -0,0 +1,283 @@
+# Copyright (c) 2024 Microchip


You should keep original copyright with the new one, even when you rename a file.

nandojve · 2024-08-01T12:11:28Z

README.md

I still think to have a platform folder name instead pic32c seems better for the long run. Then, when moving sam, sam0 they will be side by side with pic32cxsg instead creating 2 new folders on the root folder.

nandojve · 2024-08-08T11:20:15Z

Please, do not execute merge branch. Always rebase your commits (Fast Forward Only) on top of the main. The goal is to have a clean history

MyGh64605 and others added 17 commits May 6, 2024 10:02

Adding support for Microchip PIC32CX SG devices

0229627

Adding support for Microchip PIC32CX SG devices

82d8d1b

Adding support for Microchip PIC32CX SG devices

7902150

Adding support for Microchip PIC32CX SG devices

678ee3b

Adding support for Microchip PIC32CX SG devices

29156b3

Adding support for Microchip PIC32CX SG devices

7c3252a

Adding support for Microchip PIC32CX SG devices

d12239d

Adding support for Microchip PIC32CX SG devices

f026a5b

Adding support for Microchip PIC32CX SG devices

e2b7978

Adding support for Microchip PIC32CX SG devices

3002c9f

Adding support for Microchip PIC32CX SG devices

c26836d

Adding support for Microchip PIC32CX SG devices

1bf0f21

Adding support for Microchip PIC32CX SG devices

22f2a0d

Adding support for Microchip PIC32CX SG devices

e25427c

Adding support for Microchip PIC32CX SG devices

81f02ec

Adding support for Microchip PIC32CX SG devices

9e5ce86

hal: microchip: pic32cx:Adding support for Microchip PIC32CX SG devices This is based on the hal atmel libraries as a starting point. Signed-off-by: Michael Sherwood <[email protected]>

pmcgaugh force-pushed the master branch from 8bcb80b to 9e5ce86 Compare July 9, 2024 17:42

MyGh64605 marked this pull request as ready for review July 9, 2024 17:51

scottwcpg requested changes Jul 9, 2024

View reviewed changes

nandojve self-assigned this Jul 10, 2024

nandojve requested changes Jul 15, 2024

View reviewed changes

MyGh64605 added 3 commits July 18, 2024 13:42

Recommended pull request changes

e1ee8da

Renamed 'mplax' folder to 'pic32c', tested that PIC32CXSG41 and PIC32…

949f0e3

…CXSG61 boards build After running command "find * -type f -print0 | xargs -0 dos2unix -k"

Renamed 'mplax' folder to 'pic32c', tested that PIC32CXSG41 and PIC32…

c3561bb

…CXSG61 boards build After running command "find * -type f -print0 | xargs -0 dos2unix -k" Signed-off-by: Michael D Sherwood <[email protected]>

MyGh64605 and others added 2 commits July 24, 2024 11:25

Merge branch 'master' of https://github.com/MyGh64605/hal_microchip

12cdbff

pmcgaugh force-pushed the master branch from 949f0e3 to 3427508 Compare July 24, 2024 18:57

MyGh64605 added 3 commits July 25, 2024 11:03

Changed CRLF to LF in /pic32c/CMakeLists

ff9c5f2

Signed-off-by: Michael D Sherwood <[email protected]>

Update CMakeLists.txt

5dd67b9

hal: microchip: pic32cx: Changed CRLF to LF in /pic32c/CMakeLists

29a4c52

Signed-off-by: Michael D Sherwood <[email protected]>

pmcgaugh force-pushed the master branch from 5dd67b9 to 29a4c52 Compare July 30, 2024 18:04

MyGh64605 mentioned this pull request Jul 30, 2024

Adding support for Microchip PIC32CX SG devices zephyrproject-rtos/zephyr#76503

Open

nandojve requested changes Aug 1, 2024

View reviewed changes

Merge branch 'master' of https://github.com/MyGh64605/hal_microchip

26253ac

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Microchip addition of new devices PIC32CX_SG41, PIC32CX_SG60, PIC32CX_SG61 #21

Microchip addition of new devices PIC32CX_SG41, PIC32CX_SG60, PIC32CX_SG61 #21

MyGh64605 commented Jul 9, 2024

MyGh64605 commented Jul 9, 2024

MyGh64605 commented Jul 9, 2024

kartben commented Jul 9, 2024

scottwcpg left a comment

scottwcpg Jul 9, 2024

nandojve Jul 15, 2024

con-pax Jul 19, 2024

nandojve Jul 19, 2024

scottwcpg Jul 9, 2024

nandojve Aug 1, 2024

scottwcpg Jul 9, 2024

scottwcpg Jul 9, 2024

nandojve commented Jul 10, 2024 •

edited

Loading

nandojve left a comment

nandojve Jul 15, 2024

nandojve Jul 15, 2024

nandojve Jul 15, 2024

MyGh64605 Jul 18, 2024

nandojve Jul 15, 2024

MyGh64605 Jul 18, 2024

MyGh64605 Jul 18, 2024

MyGh64605 commented Jul 30, 2024

nandojve left a comment

nandojve Aug 1, 2024

nandojve Aug 1, 2024

nandojve Aug 1, 2024

nandojve commented Aug 8, 2024

Microchip addition of new devices PIC32CX_SG41, PIC32CX_SG60, PIC32CX_SG61 #21

Are you sure you want to change the base?

Microchip addition of new devices PIC32CX_SG41, PIC32CX_SG60, PIC32CX_SG61 #21

Conversation

MyGh64605 commented Jul 9, 2024

MyGh64605 commented Jul 9, 2024

MyGh64605 commented Jul 9, 2024

kartben commented Jul 9, 2024

scottwcpg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nandojve commented Jul 10, 2024 • edited Loading

nandojve left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MyGh64605 commented Jul 30, 2024

nandojve left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nandojve commented Aug 8, 2024

nandojve commented Jul 10, 2024 •

edited

Loading