Update eslint

zertosh · Oct 28, 2020 · 28aa546 · 28aa546
1 parent 7ea939a
commit 28aa546
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 270 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -0,0 +1,14 @@
+{
+  "root": true,
+  "parserOptions": {
+    "ecmaVersion": 6
+  },
+  "env": {
+    "es6": true,
+    "node": true
+  },
+  "extends": "eslint:recommended",
+  "rules": {
+    "strict": "warn"
+  }
+}
diff --git a/bench/_measure.js b/bench/_measure.js
@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 'use strict';
 
 module.exports = (name, withCache, callback) => {

diff --git a/package.json b/package.json
@@ -21,7 +21,7 @@
   "dependencies": {},
   "devDependencies": {
     "babel-core": "6.26.3",
-    "eslint": "^3.15.0",
+    "eslint": "^7.12.1",
     "flow-parser": "0.136.0",
     "rimraf": "^2.5.4",
     "rxjs": "6.6.3",

diff --git a/test/slashEscape-test.js b/test/slashEscape-test.js
@@ -13,8 +13,7 @@ var escapes = {
 };
 
 tap.test('escape', t => {
-  for (var key in escapes) {
-    if (!escapes.hasOwnProperty(key)) continue;
+  for (const key of Object.keys(escapes)) {
     t.equal(
       slashEscape(key),
       escapes[key]

diff --git a/v8-compile-cache.js b/v8-compile-cache.js
@@ -86,8 +86,6 @@ class FileSystemBlobStore {
     try {
       fs.writeFileSync(this._blobFilename, blobToStore);
       fs.writeFileSync(this._mapFilename, mapToStore);
-    } catch (error) {
-      throw error;
     } finally {
       fs.unlinkSync(this._lockFilename);
     }
@@ -301,7 +299,8 @@ function slashEscape(str) {
     '\x00': 'z0',
     'z': 'zZ',
   };
-  return str.replace(/[\\:\/\x00z]/g, match => (ESCAPE_LOOKUP[match]));
+  const ESCAPE_REGEX = /[\\:/\x00z]/g; // eslint-disable-line no-control-regex
+  return str.replace(ESCAPE_REGEX, match => ESCAPE_LOOKUP[match]);
 }
 
 function supportsCachedData() {
@@ -348,7 +347,7 @@ if (!process.env.DISABLE_V8_COMPILE_CACHE && supportsCachedData()) {
   nativeCompileCache.setCacheStore(blobStore);
   nativeCompileCache.install();
 
-  process.once('exit', code => {
+  process.once('exit', () => {
     if (blobStore.isDirty()) {
       blobStore.save();
     }