Fix crashes when using Byte Spans. #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing crashes using byte spans when byte spans start or end in whitespace after a line. When I write the code I did not expect get_line_text to trim whitespace. I edited uses of get_line_text to do the trimming separately. Technically this is a breaking change.
zesterer
reviewed
Mar 27, 2024
src/write.rs
Outdated
Comment on lines
1015
to
1016
| for i in 0..source.len() { | ||
| for j in i..source.len() { |
There was a problem hiding this comment.
The ranges should probably be ..= here.
There was a problem hiding this comment.
Oh, good catch, is it possible to amend a PR?
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does include a breaking change, namely Source::get_line_text now returns the full line, including trailing whitespace and newline.
It also includes a new test, ensuring that no possible byte span in a small excerpt causes a crash.