-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: cargo clippy
and cargo fmt
#110
Conversation
cargo clippy
and cargo fmt
cargo clippy
and cargo fmt
- Clippy and fmt in CI
ed94097
to
e97c3e2
Compare
Thanks for the PR. I'll admit that I think that rustfmt has royally screwed up the legibility of the code (at least, what little legibility there was to begin with), but I guess that's an unfortunate compromise to have to make given that this crate is attracting more contributors and many folks have their editor autoformat everything by default. Fwiw most of my time (or, at least, time that I dedicate to this crate's development) is going on the |
Looks like there's still a complaint from clippy. |
06df8b5
to
89c9aba
Compare
Yeah,
Yeah I just disabled that lint in the code. Fixing it was going to make the test quite unreadable.. Clippy suggested |
Thanks for the PR! |
Runs
cargo fmt
andcargo clippy
and fixes any issues that came up. It also adds those two steps to CI.This is just a suggestion so feel free to close this PR. I just find it a good practice to make sure both tools are run with every PR to improve code quality.