fix(libs): fix OHW decorator counter, refactor

zhibirc · Dec 14, 2023 · 4ad8da2 · 4ad8da2
1 parent 26a42fd
commit 4ad8da2
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 19 deletions.
diff --git a/fifo-cache/spec.ts b/fifo-cache/spec.ts
@@ -1,5 +1,6 @@
 import { describe, it } from 'node:test';
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
+import FifoCache from './index';
 
 describe('Test FIFO cache API', () => {
     it('Create FIFO cache instance', () => {

diff --git a/libs/decorators/detect-one-hit-wonder.ts b/libs/decorators/detect-one-hit-wonder.ts
@@ -12,32 +12,34 @@ const TYPE_FILTER_CUCKOO = Symbol('TYPE_FILTER_CUCKOO');
 const detectOneHitWonder = (() => {
     let filter;
 
-    return (threshold: number = 1, filterType: symbol = TYPE_FILTER_MAP) => {
+    return (filterType: symbol = TYPE_FILTER_MAP) => {
         return function (originalMethod: any, _context: ClassMethodDecoratorContext) {
             function replacementMethod(this: any, key: any, value?: any) {
-                const { capacity } = this.stats;
+                if (!filter) {
+                    const { capacity } = this.stats;
 
-                switch (filterType) {
-                    case TYPE_FILTER_MAP:
-                        filter = new Map();
-                        break;
-                    case TYPE_FILTER_BLOOM:
-                        filter = new BloomFilter(capacity);
-                        break;
-                    case TYPE_FILTER_CUCKOO:
-                        filter = new CuckooFilter(capacity);
-                        break;
+                    switch (filterType) {
+                        case TYPE_FILTER_MAP:
+                            filter = new Map();
+                            break;
+                        case TYPE_FILTER_BLOOM:
+                            filter = new BloomFilter(capacity);
+                            break;
+                        case TYPE_FILTER_CUCKOO:
+                            filter = new CuckooFilter(capacity);
+                            break;
+                    }
                 }
-                let n = filter.get(key) ?? 0;
-
-                filter.set(key, ++n);
 
                 switch (originalMethod.name) {
                     case 'read':
+                        filter.set(key, 1);
                         return originalMethod.call(this, key);
                     case 'add':
-                        if (n > threshold) {
+                        if (filter.get(key)) {
                             return originalMethod.call(this, key, value);
+                        } else {
+                            filter.set(key, 1);
                         }
                 }
             }

diff --git a/libs/get-typed-array.ts b/libs/get-typed-array.ts
@@ -11,7 +11,7 @@ function getTypedArray (n: number) {
         case n - 1 <= MAX_32BIT_UINT:
             return new Uint32Array(n);
         default:
-            return new Array(n);
+            return new Float64Array(n);
     }
 }
 

diff --git a/rr-cache/spec.ts b/rr-cache/spec.ts
@@ -1,5 +1,6 @@
 import { describe, it } from 'node:test';
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
+import RRCache from './index';
 
 describe('Test RR cache API', () => {
     it('Create RR cache instance', () => {