Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added highlight groups for color scheme usage #22

Merged
merged 4 commits into from
Apr 1, 2023

Conversation

theSafdarAwan
Copy link
Contributor

Hello, @ziontee113. I have added the highlight groups for the neo-minap window i think some people will find it easier to configure the UI appearance of the neo-minimap , if highlight groups were exposed. Thanks.

@theSafdarAwan
Copy link
Contributor Author

Any way, advanced user can override these highlight groups using the win_opts.winhl option. But some people don't know these options deeply so this is an easier way for those user to change highlight groups. And also color schemes can integrate these groups easily.

@theSafdarAwan
Copy link
Contributor Author

I didn't remove the hl_group in the setup_defaults opts after adding the NeoMinimapLineNr hl. Maybe deprecate the hl_group opt.

@ziontee113 ziontee113 merged commit 76e792b into ziontee113:master Apr 1, 2023
@ziontee113
Copy link
Owner

ziontee113 commented Apr 1, 2023

advanced user can override these highlight groups using the win_opts.winhl option. But some people don't know these options deeply so this is an easier way for those user to change highlight groups. And also color schemes can integrate these groups easily.

This statement helped me a lot. Thank you very much for your hard work 👍

@theSafdarAwan
Copy link
Contributor Author

h

Thanks for creating this amazing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants