Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shield): Add Hillside support #1047

Closed
wants to merge 1 commit into from
Closed

feat(shield): Add Hillside support #1047

wants to merge 1 commit into from

Conversation

mmccoyd
Copy link

@mmccoyd mmccoyd commented Dec 5, 2021

Add Hillside support, tested on real hardware. (https://github.com/mmccoyd/hillside)

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • .conf file has optional extra features commented out

@Nicell Nicell self-assigned this Dec 6, 2021
@Nicell Nicell added enhancement New feature or request shields PRs and issues related to shields labels Dec 6, 2021
@Nicell
Copy link
Member

Nicell commented Dec 13, 2021

Hi @mmccoyd, thanks for the PR! I'm wondering what the availability of this shield is? Is there a group buy or general availability planned, or is this strictly OSH at the moment? To lighten the review load we are only putting group buy or generally available shields in the main repository for now. OSH projects can take advantage of zmk-config repositories to share firmware. Thanks for your understanding 😄

@mmccoyd
Copy link
Author

mmccoyd commented Dec 13, 2021

Nicell, It is OSH only at this point and I've got a public zmk-config for it. Thanks for the work on ZMK.

@Nicell
Copy link
Member

Nicell commented Jan 30, 2022

I'm going to close this PR for now since there isn't wide availability, but please let us know if this changes in the future!

@Nicell Nicell closed this Jan 30, 2022
@mmccoyd mmccoyd deleted the hillside branch February 1, 2022 06:30
@kkga
Copy link

kkga commented Feb 1, 2022

I'm building the Hillside right now, so there's at least one more person who would want this upstream 🙃

@Nicell
Copy link
Member

Nicell commented Feb 1, 2022

Hi @kkga, you can use the zmk-config that mmccoyd has created in the Hillside repository: https://github.com/mmccoyd/zmk-config

@alternateved
Copy link

It seems that it gained traction. At least it is available in Beekeeb shop https://shop.beekeeb.com/product/hillside-keyboard-kit/. Would that be enough to add support upstream for that board?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shields PRs and issues related to shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants