Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(board): add Hannah60B to board #1448

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mechlovin
Copy link

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

@mechlovin mechlovin changed the title Add Hannah60B to board feat(board): add Hannah60B to board Sep 7, 2022
@petejohanson
Copy link
Contributor

The PR seems good to me, code wise, but I didn't actually find this for sale at the URL in the metadata.

Is this available soon? Going to be in GB or stocked?

We tend to avoid merging small runs, one offs, etc favoring separate ZMK config repos for that case.

@petejohanson petejohanson self-assigned this Nov 4, 2022
@petejohanson petejohanson added board PRs and issues related to boards. enhancement New feature or request labels Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board PRs and issues related to boards. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants