-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Underglow): Momentary effect selection #1457
base: main
Are you sure you want to change the base?
Conversation
65834d9
to
9e9b5f5
Compare
I've edited the documentation to note the new command as well as notes around an edge case when it's powered off with the key held down. Thinking about this I've realised the functionality can now be done using a parameterised macro too, however i think a dedicated behaviour command still has value. A parameterised macro would also present the same issue on the edge case when it's powered off with the key held down, I cant think of a good way to mitigate this (If anyone has ideas i'm happy to implement them) |
I think the macro approach would hit #1494 as well, and I assume this works without issues for splits. |
I'll double check, a variant of this has been in use on the 360 Pro but the 360 pro doesn't use the standard locality implementation |
30cd263
to
1407829
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small nit on the formatting in the table.
1076b7e
to
829b75b
Compare
Adds the ability to have an RGB effect select whilst held down and revert when release
Co-Authored-By: Cem Aksoylar <[email protected]>
Studio metadata has now been added. I think I've done it right but would appreciate someone more knowledgeable on the metadata looking over it |
Adds the ability to have an RGB effect select whilst held down and revert when released.
Designed to be used in conjunction with #1456 to allow for momentary battery indication through the lighting by holding down a specific key