-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(boards): Add Corne-ish Zen v1 #1593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments.
Thanks @caksoylar! Currently testing with this build (current ZMK main, mousekeys enabled, layer widget disabled): https://github.com/manna-harbour/miryoku_zmk/actions/runs/3727371035. |
179af66
to
baa1c02
Compare
Haven't noticed any issues since I started testing. |
We had another user confirm on the LPKB Discord so I am publishing the PR for review. |
Confirmed to be working on my Corne-ish Zen v1 and no issues so far either. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple questions. Thanks.
0b5141c
to
8180b7a
Compare
Rebased and have been testing (just the right side) OK for a few days now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@caksoylar Looks like the pre-commit check is still not happy with this. |
I hadn't managed to install pre-commit locally properly, hope it's all good now! |
This PR does some minor refactoring for existing Corne-ish Zen v2 files and adds files for Corne-ish Zen v1 (for GB rounds 1&2).
compatible
andmodel
values in the DTv1's differences compared to v2 are:
int-gpios
that was necessary for deep sleep in Zephyr 3.xspi2
instead ofspi0
since fuel gauge usesi2c0
For v2 refactorings the produced DTS and Kconfig files after a build are identical to
main
except formodel
andcompatible
values that removed v2. Tested right side on real v1 hardware, although I have been using a (non-unified) branch with the same config until my v1 left side died.Board/Shield Check-list
.zmk.yml
metadata file added&pro_micro
used in favor of&pro_micro_d/a
if applicable.conf
file has optional extra features commented out