-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behaviors): Add a send string behavior #1893
base: main
Are you sure you want to change the base?
Conversation
I will do a second pass later but the docs look great, thank you for the effort you put into it! One suggestion I'd have is to put a pointer in the macros page pointing to this behavior for string sending purposes, similar to the pointer we have for modifier functions. |
I've been waiting for this function. If there is a printf-style format function, I would be more than happy. Once I read the zephyr's code related to printf, It's difficult to understand to me. |
Good idea. I'll add that.
You could use the struct zmk_send_string_config config = {
.character_map = DEVICE_DT_GET(DT_CHOSEN(zmk_character_map)),
.wait_ms = CONFIG_ZMK_SEND_STRING_DEFAULT_WAIT_MS,
.tap_ms = CONFIG_ZMK_SEND_STRING_DEFAULT_TAP_MS,
};
char string[32];
snprintf(string, sizeof(string), "Battery level is %u%%", zmk_battery_state_of_charge());
zmk_send_string(&config, position, string); |
6a931b7
to
4ec46cd
Compare
I added some macros for creating the config structs, so the code example above can now be simplified to ZMK_BUILD_ASSERT_CHARACTER_MAP_CHOSEN();
...
char string[32];
snprintf(string, sizeof(string), "Battery level is %u%%", zmk_battery_state_of_charge());
zmk_send_string(&ZMK_SEND_STRING_CONFIG_DEFAULT, position, string); |
LGTM from a docs perspective 👍 |
pr broken because of this? 690bc1b |
Will be great if this gets merged! |
320c327
to
7ce38da
Compare
Rebased and fixed everything to work with current ZMK. |
This adds the following: - A character map driver API, which maps Unicode code points to behavior bindings. - A zmk,character-map driver which implements this API. This driver is designed for ROM efficiency, so it sends every value defined in the map to one behavior and passes any code point not in the map through to another. (A more flexible implementation that allows for a unique behavior binding per character could be added later if necessary.) - A zmk,send-string behavior, which users can define and bind to their keymaps to send strings. - A zmk_send_string() function, which queues the necessary behaviors to type a UTF-8 string. This is separated from the send string behavior since it could be used for other features such as Unicode key sequences, behaviors that print dynamic messages, etc.
7ce38da
to
76ffce6
Compare
I've been eagerly waiting for this for almost a year now. Is there any chance we'll get to see this merged soon? Thank you! |
This adds the following: