-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spacecat.design Launchpad to shields #703
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. The shield setup looks correct to me, though I've commented on a few things that could be cleaned up.
@Nicell or one of the other shield reviewers should also double check that I didn't miss anything.
config ZMK_KEYBOARD_NAME | ||
default "LaunchPad" | ||
|
||
config ZMK_USB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason you explicitly enabled USB here? That's usually handled by the board instead of the shield.
# Copyright (c) 2020 The ZMK Contributors | ||
# SPDX-License-Identifier: MIT | ||
|
||
CONFIG_BT_MAX_CONN=6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the default keymap doesn't have options for using six bluetooth connections. Unless there's a good reason to do otherwise, I think we should leave this at the default.
*/ | ||
|
||
#include <behaviors.dtsi> | ||
#include <dt-bindings/zmk/bt.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be unused (no &bt
bindings in the keymap).
#include <behaviors.dtsi> | ||
#include <dt-bindings/zmk/bt.h> | ||
#include <dt-bindings/zmk/keys.h> | ||
#include <dt-bindings/zmk/ext_power.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be unused (no &ext_power
bindings in the keymap).
#define _FUNC 1 | ||
#define _ADMIN 2 | ||
|
||
/ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how feasible it is on such a tiny macropad, but finding a way to fit in &bt BT_CLR
and maybe &bt BT_NXT
and &bt BT_PRV
might be useful.
* SPDX-License-Identifier: MIT | ||
*/ | ||
|
||
#include <dt-bindings/zmk/matrix_transform.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused (shield doesn't use a matrix transform).
Thank you, contributor, for your patience with how long review and merge of boards/shields has taken! There are three recent refactors/changes to boards and shields that require some attention, and then we can finally get this PR merged!
Hardware MetadataThe ProblemWhen first developing the process around contributing new shields/boards to ZMK, we failed to recognize that several key files (setup scripts, documentation page of supported hardware, and GH Action The FixBy adding discrete metadata files that are located with the boards/shields in question, and using that metadata to generate setup scripts, website hardware list, etc., users can contributing new hardware descriptions without the need to change the same files that other contributors are changing. Next StepsFirst, refer to https://zmk.dev/docs/development/hardware-metadata-files to familiarize yourself with the new metadata file format. Next, you have two options for fixing up your PR:
Pro Micro shield DT naming changesIn #876, we have simplified the DT naming for the "nexus node" we expose for pro-micro compatible boards, deprecating the use of Please see https://zmk.dev/docs/development/new-shield#shield-overlays for the updated docs on this. Split Shield Advertising ChangesIn addition, if this is a split PR, please see #658 where we have changed our conventions to remove the the name from the right sides, to prevent users attempting to pair with them and causing split sync issues. This also includes removing the " Left" suffix from the naming on the left side. See the changes in that PR for examples of what to change with your split shield. Getting HelpIf you have any questions about any of these changes, please comment here and tag @zmkfirmware/boards-shields or ask in the |
Hello! We're closing this PR due to there being no activity since the metadata update to ZMK in September of last year. If you are still interested in updating this PR, please let us know, and we can reopen it and review your changes (hopefully a lot faster this time)! |
No description provided.