Merge pull request #143 from zowe-actions/fix/make-ovsx-publish-optional

Make OVSX publish optional since it is flaky

packages/github/src/success.ts

@@ -44,11 +44,14 @@ export default async function (context: IContext, config: IPluginConfig): Promis
             packageList.push(`**${pkgType}**: ${pkgName}`);
         }
     }
+    const releaseMessage = packageList.some(line => line.includes("❌")) ?
+        `Release succeeded for the \`${context.branch.name}\` branch with some errors. :warning:` :
+        `Release succeeded for the \`${context.branch.name}\` branch. :tada:`;
     await coreUtils.dryRunTask(context, "create success comment on pull request", async () => {
         await octokit.rest.issues.createComment({
             ...context.ci.repo,
             issue_number: prNumber,
-            body: `Release succeeded for the \`${context.branch.name}\` branch. :tada:\n\n` +
+            body: `${releaseMessage}\n\n` +
                 `The following packages have been published:\n` +
                 packageList.map(line => `* ${line}`).join("\n") + `\n\n` +
                 `<sub>Powered by Octorelease :rocket:</sub>`

packages/vsce/src/publish.ts

@@ -60,14 +60,20 @@ export default async function (context: IContext, config: IPluginConfig): Promis
     if (config.ovsxPublish) {
         const ovsxMetadata = await utils.ovsxInfo(extensionName) || {};
         if (!Object.keys(ovsxMetadata.allVersions || {}).includes(packageJson.version)) {
-            await utils.ovsxPublish(context, vsixPath);
+            let success = true;
+            try {
+                await utils.ovsxPublish(context, vsixPath);
+            } catch (err) {
+                context.logger.error((err as any).toString());
+                success = false;
+            }
 
             context.releasedPackages.vsce = [
                 ...(context.releasedPackages.vsce || []),
-                {
+                success ? {
                     name: `${extensionName}@${packageJson.version} (OVSX)`,
                     url: `https://open-vsx.org/extension/${extensionName.replace(".", "/")}/${packageJson.version}`
-                }
+                } : { name: `❌ ${extensionName}@${packageJson.version} (OVSX)` }
             ];
         } else {
             context.logger.error(`Version ${packageJson.version} has already been published to Open VSX Registry`);