Don't use Lerna for independent versioning #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
zFernand0
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Changes LGTM! 😋
I had to look where the context.version.overrides was defined in order to understand the weird ternary
Also, thanks for sharing a before and after links for the fix 🙏🏽
traeok
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue for the Zowe CLI monorepo where if the only changes in a new version are within the Imperative package, then SDKs which depend on Imperative are not updated like they should be.
Here is the CLI PR where the error was encountered: zowe/zowe-cli#2172
And here are PRs from zowe-deploy-test repo showing before and after the fix
Many files changed in this PR due to copyright updates, but the main one to review is
packages/lerna/src/version.ts